Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Only display wallets for selected platform #629
Conversation
|
LGTM |
|
LGTM also. That certainly does declutter the interface. Thanks! |
|
@schildbach @harding Thanks! In the absence of critical feedback, this pull request will be merged on November 3th. |
saivann
added a commit
that referenced
this pull request
Nov 3, 2014
saivann
merged commit 971b224
into
master
Nov 3, 2014
saivann
deleted the
walletsscale branch
Nov 3, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
saivann commentedNov 1, 2014
Live preview: (Merged)
This change allows the page to scale better with the increasing number of wallets by displaying only selected wallets. This way the page can display more wallets on two lines instead of three, and prevent the education disclaimer to be buried too far at the end of the page.
This also allows to avoid a layout with too much greyed out entries, which can be counter-intuitive, and avoid providing too much choice by default (to not fall too much into the paradox of choice). At some point, a "Show all" button could be added to display more than 12 wallets.
At the same time, this pull req fixes issue #488.