Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add mentions and definitions for bits #636

Merged
merged 8 commits into from Nov 11, 2014

Conversation

Projects
None yet
4 participants
Contributor

saivann commented Nov 8, 2014

Live preview: (Merged)

"Bits" seems to be passing the test of time with a rough consensus in the community, quite strong support on social networks, positive comments from developers and increasing adoption by users, wallets and merchant tools. Recent experiments with changetips also seem to show bits are fixing design issues for the end user.

This pull req adds a mention for bits where other units are mentioned and a definition both in the vocabulary and devel-docs. To avoid confusion in devel-docs, microbit and millibit are renamed to microbitcoin and millibitcoin.

Maybe at some point in the future, using bits instead of mBTC in devel-docs's images and examples could also be worth considering?

@harding harding commented on an outdated diff Nov 8, 2014

_translations/en.yml
@@ -325,7 +325,7 @@ en:
earlyadopter: "Doesn't Bitcoin unfairly benefit early adopters?"
earlyadoptertxt1: "Some early adopters have large numbers of bitcoins because they took risks and invested time and resources in an unproven technology that was hardly used by anyone and that was much harder to secure properly. Many early adopters spent large numbers of bitcoins quite a few times before they became valuable or bought only small amounts and didn't make huge gains. There is no guarantee that the price of a bitcoin will increase or drop. This is very similar to investing in an early startup that can either gain value through its usefulness and popularity, or just never break through. Bitcoin is still in its infancy, and it has been designed with a very long-term view; it is hard to imagine how it could be less biased towards early adopters, and today's users may or may not be the early adopters of tomorrow."
finitelimitation: "Won't the finite amount of bitcoins be a limitation?"
- finitelimitationtxt1: "Bitcoin is unique in that only 21 million bitcoins will ever be created. However, this will never be a limitation because bitcoins can be divided up to 8 decimal places ( 0.000 000 01 BTC ) and potentially even smaller units if that is ever required in the future. As the average transaction size decreases, transactions can be denominated in sub-units of a bitcoin, such as millibitcoins ( 1 mBTC or 0.001 BTC )."
+ finitelimitationtxt1: "Bitcoin is unique in that only 21 million bitcoins will ever be created. However, this will never be a limitation because transactions can be denominated in smaller sub-units of a bitcoin, such as bits - there is 1,000,000 bits in 1 bitcoin. Bitcoins can be divided up to 8 decimal places (0.000 000 01) and potentially even smaller units if that is ever required in the future as the average transaction size decreases."
@harding

harding Nov 8, 2014

Contributor

s/there is 1,000,000/there are 1,000,000/

Contributor

harding commented Nov 8, 2014

Dev docs changes LGTM. Except for the note above, the other text changes LGTM also. Thanks!

Updating the micropayment channel illustration to use satoshis like the other examples has been on my low-priority todo list for ages; now that op_checklocktimeverify is under discussion, I'll probably wait for it to be merged and then update the entire section to use it.

Contributor

saivann commented Nov 8, 2014

@harding Agreed, satoshis make more sense in devel-docs.

Would it make sense to add thousands separators after the decimal mark (for better readability)?

capture du 2014-11-07 22 06 24

Contributor

harding commented Nov 8, 2014

@saivann I kind of like the way you did it in part of the main site with a space. However---and I haven't really thought this through---it seems to me the separator mark should separate hundredths from thousandths and hundreds of thousandths from millionths, as those seem to be logical groupings to me. E.g. satoshis should be 0.00 000 001.

But, like I said, I really haven't thought about, so whatever you think is best works for me.

Contributor

luke-jr commented Nov 8, 2014

Disagree, the only "rough consensus" I've seen is opposition to "bits", and even the notable people who support it seem to agree it is merely an informal way to refer to microbitcoins.

jgarzik commented Nov 8, 2014

Yes, "bits" is certainly informal and always will be.

Contributor

saivann commented Nov 8, 2014

After more reading, it is true that I may be over-estimating the consensus on this, although I still find a lot of support too, so I have reverted parts of this pull req so bitcoin.org doesn't "push" for bits, and only make sure it's defined and used in one FAQ example.

I guess my point is that this term is being commonly used today, especially for tipping, and is adopted or being adopted by major businesses in the space (Coinbase, BlockChain, KnC, Xapo and BitPay), and therefore is worth at least being documented for that reason.

This pull request actually also makes the language more neutral with both "bits" and "BTC", as otherwise BTC is currently described more or less like the official ISO unit, although there's no such thing.

Contributor

harding commented Nov 8, 2014

@saivann oh, I just noticed that bits is autocrossref'd in the dev docs, leading to collisions with binary bits. For example, see the bloom filter section: http://bitcointest1.us.to/en/developer-guide#bloom-filters

As binary bits will likely always be more common in the dev docs, I recommend removing the autoxref and using manual links, perhaps using the autoxref format: [bits][]{:.auto-link}

@luke-jr luke-jr commented on an outdated diff Nov 8, 2014

_includes/guide_payment_processing.md
Bitcoin wallet software defaults to denominating amounts in either [bitcoins][]{:#term-bitcoins}{:.term} (BTC)
-or [millibits][]{:#term-millibits}{:.term} (mBTC). Choosing between BTC and mBTC is widely supported,
+, [millibitcoins][]{:#term-millibitcoins}{:.term} (mBTC) or [bits][]{:#term-bits}{:.term}. Choosing between BTC, mBTC and bits is widely supported,
@luke-jr

luke-jr Nov 8, 2014

Contributor

µBTC (aka "bits")

Contributor

saivann commented Nov 8, 2014

@harding Thanks! I indeed forgot to check for collisions, will disable it in a moment.

@luke-jr luke-jr commented on an outdated diff Nov 8, 2014

_includes/references.md
@@ -6,6 +6,7 @@
[base58Check]: /en/developer-reference#term-base58check "The method used in Bitcoin for converting 160-bit hashes into Bitcoin addresses"
[bitcoin URI]: /en/developer-guide#term-bitcoin-uri "A URI which allows receivers to encode payment details so spenders don't have to manually enter addresses and other details"
[bitcoins]: /en/developer-guide#term-bitcoins "A primary accounting unit used in Bitcoin; 100 million satoshis"
+[bits]: /en/developer-guide#term-bits "0.000,001 bitcoins (100 satoshis)"
@luke-jr

luke-jr Nov 8, 2014

Contributor

Half-spaces seem standard for post-decimal delimiting.

Contributor

saivann commented Nov 9, 2014

In the absence of critical feedback, this pull request will be merged on November 11th.

saivann added a commit that referenced this pull request Nov 11, 2014

Merge pull request #636 from bitcoin/bits
Add mentions and definitions for bits

@saivann saivann merged commit b9a6c10 into master Nov 11, 2014

@saivann saivann deleted the bits branch Nov 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment