/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add contextual link to source file on GitHub in devel-doc #648

Merged
merged 2 commits into from Nov 18, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@saivann @harding @icook
@saivann
Contributor

saivann commented Nov 17, 2014

As discussed in #647

Live preview: (Merged)

In the absence of critical feedback, this pull request will be merged on November 18th.
@harding
Contributor

harding commented Nov 17, 2014

Tested all three dev docs content pages with both Iceweasel (Firefox) and Chromium. No bugs found, so LGTM. Thanks!

@icook icook commented on an outdated diff Nov 17, 2014

View full outdated diff
en/developer-reference.md
@@ -52,10 +63,22 @@ create a cross-site scripting (XSS) exploit. To avoid problems, please
treat block chain and memory pool data as an arbitrary input from an
untrusted source.
+<div class="sourcefile" data-sourcefile="ref_core_rpc_abcdefg.md"></div>
@icook

icook Nov 17, 2014

These links are just barely wrong, - instead of _ on the last separator.
@icook

icook commented Nov 17, 2014

Other than the minor typo looks great! Thanks for all the work.
@saivann
Contributor

saivann commented Nov 17, 2014

@icook Good catch! Fixed and updated the live preview.

saivann added a commit that referenced this pull request Nov 18, 2014

@saivann
Merge pull request #648 from bitcoin/develdocedit 
Add contextual link to source file on GitHub in devel-doc
42df526

@saivann saivann merged commit 42df526 into master Nov 18, 2014

@saivann saivann deleted the develdocedit branch Nov 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment