Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Dev Docs: Describe Almost All Remaining P2P Network Messages #649

Merged
merged 3 commits into from Nov 22, 2014

Conversation

Projects
None yet
2 participants
Contributor

harding commented Nov 17, 2014

Preview: http://dg0.dtrt.org/en/developer-reference#control-messages

  • Describes all remaining messages except filterload. Specificially, the following messages are described: Addr, Alert, FilterAdd, FilterClear, GetAddr, Ping, Pong, Reject, VerAck, and Version
  • New makefile test: report broken markdown tables
  • Put relevant protocol version changes at the top of all message subsections.

Notes: describing filterload is next on my todo list (it's a bit more complicated than the other messages in this pull). This pull does not describe Bitcoin Core's Tor-compatible features; I don't know much about Tor and learning about it is low on my todo list.

@saivann saivann commented on the diff Nov 21, 2014

_includes/ref_p2p_networking.md
+{% highlight text %}
+0094102111e2af4d ... Nonce
+{% endhighlight %}
+
+{% endautocrossref %}
+
+#### Pong
+
+{% autocrossref %}
+
+*Added in protocol version 60001 as described by BIP31.*
+
+The `pong` message replies to a `ping` message, proving to the pinging
+node that the ponging node is still alive. Bitcoin Core will, by
+default, disconnect from any clients which have not responded to a
+`ping` message within 20 minutes.
@saivann

saivann Nov 21, 2014

Contributor

@harding There is really a 20 minutes timeout? This one seemed surprising to me.

@harding

harding Nov 21, 2014

Contributor

There is, unless I'm reading the code wrong. See here and here

@saivann

saivann Nov 21, 2014

Contributor

@harding That indeed looks like it, thanks!

Contributor

saivann commented Nov 21, 2014

@harding I just sent you two pull requests to fix minor details. Otherwise texts are very clear and well explained!

harding added some commits Nov 21, 2014

Contributor

harding commented Nov 21, 2014

@saivann thanks for the review! (I know I said this would probably be the last big pull for a while, but the filterload documentation is already nearly as long as this. Grrr.)

I think commit f26a57e addresses our discussion about putting changes in the tables; please let me know if I missed something. Thanks again!

In the absence of critical feedback, I'll merge this around 02:00 UTC Saturday.

@harding harding merged commit f26a57e into bitcoin-dot-org:master Nov 22, 2014

harding added a commit that referenced this pull request Nov 22, 2014

@harding harding deleted the harding:control-messages branch Feb 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment