Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add a "Privacy" page and link to public stats (fixes #605) #650
Conversation
harding
commented on an outdated diff
Nov 17, 2014
| @@ -475,6 +475,13 @@ en: | ||
| faqmore: "To learn more about Bitcoin, please visit the complete <a href=\"/en/faq\">FAQ</a> or the <a href=\"https://en.bitcoin.it/wiki/FAQ\">Bitcoin Wiki</a>." | ||
| materialpicture: "Pictures" | ||
| materialpicturemore: "Show more pictures..." | ||
| + privacy: | ||
| + title: "Privacy - Bitcoin" | ||
| + pagetitle: "Privacy" | ||
| + datacollect: "Data collected" | ||
| + datacollecttxt: "Bitcoin.org collects anonymized server logs. These logs include IP addresses with replaced last bit, time of the visit, requested page, user agent and referer url. Bitcoin.org does not collect data using cookies." |
harding
Contributor
|
|
LGTM, except for the nitpick above. |
|
Rebased on master to fix merge conflict. |
saivann
added some commits
Nov 17, 2014
|
(Rebased again to fix another merge conflict and merging) @gurnec Unfortunately, due to some EU laws, server logs are now anonymized at the server level, so your nice solution for keeping the unique user count will be overridden at least in the near future :( . |
saivann
added a commit
that referenced
this pull request
Nov 22, 2014
saivann
merged commit 8486f9c
into
master
Nov 22, 2014
saivann
deleted the
statsprivacy branch
Nov 22, 2014
|
@saivann That's too bad-- I know you put plenty of work into it. C'est la vie... |
|
@gurnec That's a great feature regardless and may prove useful in the future. Thanks for the time you've spent on it! |
saivann commentedNov 17, 2014
Live preview: (Merged)
Note: The link to public stats is expected to be not working on the live preview because "/stats/" only exists on https://bitcoin.org/stats/.
Public stats seem to be working fine so now may be a good time to add a link to it and a "Privacy" page. I've had the confirmation that as long as we are not using cookies and not collecting personal data - as in data identifying a real person, this simple "Privacy" page is appropriate.
This pull request also makes some reorganization in the footer and CSS otherwise space would be missing.