Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Set license files and headers for bitcoin.org's content #655
Conversation
|
Untested ACK: I read the diff but haven't test built the site. Also, for posterity:
|
saivann
merged commit bc69bf5
into
master
Nov 28, 2014
saivann
deleted the
license branch
Nov 29, 2014
|
In order for a license change to occur you need the permission of each contributor. A random check of files has shown several files with more contributors than @saivann and @harding You cannot apply license to files with mutliple contributors since each author owns their copyright, you need individual permission. This particular PR is in fact illegal. |
|
@btcdrak several contributors were contacted via email by @saivann and asked about this; I was CC'd on some messages. Every single person I saw respond said that they were under the impression that the site was already MIT licensed because, as the PR message says, the site footer has always said "Released under the MIT license". You can verify this yourself: here's the initial commit: cb7f7af This was not a license change. |
|
Specifically where was the license defined in the first place? You realise the repo needed the license text in the repository as well as MIT headers on each file to in fact license them. All that appears in the initial source is an MIT notice on the footer template and it's not even clear what the MIT notice refers to, "the project" seems to refer more to the software than the site remembering at the time the site was created there was only bitcoin core. |
Yes, which is why this PR exists. We who contributed content believed we were contributing under the MIT license, but @saivann realized that we were not complying with the terms of the license. So now we comply with it. You seem to be under the assumption that because we previously didn't fully comply with the license, we're not allowed to fully comply with the license. |
No, I am saying it isn't clear if every contributor of each file has given permission for the change. Normally there would need to be a record of this. |
|
@btcdrak I can't parse your sentence above. Could you rephrase? |
|
golly. what happened there...? I edited my post. |
|
@btcdrak as posted earlier, several people were contacted about this, and in all the emails I saw, they all agreed that they had contributed under the belief that their content was MIT licensed. If you think there's someone out there who believes that they contributed under a different license, please have them contact @saivann or myself. |
|
@btcdrak For the record, I hired a lawyer when I was working on that issue to make sure things were done correctly. |
saivann commentedNov 22, 2014
The license for the content on bitcoin.org needs more clarity.
Although the MIT license was mentioned in the footer of the website since the first commit, the website didn't provide licensing information in the usual locations (file headers or COPYING files), except for the libraries and files under different copyright owners or licenses than MIT.
This pull request fixes that issue while carefully avoiding ambiguity or conflicts between multiple licenses with a per-file or per-folder licensing. For this reason, all images under img/ have been moved to a subfolder (I should have carefully tested all layouts with this change).
In the absence of critical feedback, this pull request will be merged on November 28th.
A list of files and folders under a different, or slightly different license or copyright owner:
/_less/normalize.less
/csshover.htc
/font/ubuntu
/font/droidnaskh
/js/leaflet
/js/leaflet-markercluster
/img/flags
/img/brand
/img/wallets
/img/screenshots
/img/faq
/img/innovation
/img/press
/img/os