Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Fix statement about "majority of miners" #713
Conversation
|
LGTM, although as a nitpick, I'd say "hash rate" instead of "hashrate". |
Agreed, I will make that change. Btw, how do you feel about "a majority of network-total miner hash rate"? I am trying to make this maximally unambiguous.... |
|
Hmm, talking about hash rate is probably ambiguous here anyway. Really this could be simplified by instead talking about proof-of-work. Unfortunately this just boils down to "valid proofs of work are valid and correct nodes will accept valid proofs of work that meet the other requirements for blockchain tip acceptance". |
|
Does this sound better: "Miners controlling the majority of the hash rate..."? Or if "hash rate" is too technical, it could be "computing power". |
|
@saivann since even a powerful minority could make the attack described in that parapgrah, we could probably just simplify down to: "However, powerful miners could..." |
|
@kanzure Thanks for updating your branch, but I guess you accidentally used "powerful mining" instead of "powerful miners"? |
You caught me! (fixed) |
saivann
merged commit 9d6b832
into
bitcoin-dot-org:master
Jan 20, 2015
|
@kanzure No problem :) Thanks for the pull request! |
kanzure commentedJan 18, 2015
Instead of talking about a majority of miners, it is better to talk about a majority of available hashrate. There is no way to determine the number of miners that exist, and it is confusing to talk about a "majority of miners" as a consequence of this and other reasons.
The original version of the statement was:
And this changes it to say:
There may be other errors lurking in this block.