Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Order release history and set latest version using versions number instead of releases date #714

Merged
merged 1 commit into from Jan 21, 2015

Conversation

Projects
None yet
2 participants
Contributor

saivann commented Jan 19, 2015

This comment outlined that releases numbers might not always be in chronological order (e.g. 0.9.5 to be released after 0.10.0) which would affect the version served on the download page as well as the order on the version history page.

This pull request should prevent this issue as long as version numbers do not use more decimal places or digits than this example "000.000.000.000.000" .

In the absence of critical feedback, this pull request will be merged on January 21th.

Contributor

harding commented Jan 19, 2015

@saivann glad you caught that for the downloads page!

I don't think it's a big deal either way, but it seems to me like the release history page should be in chronological order.

Contributor

saivann commented Jan 19, 2015

@harding This would actually create a "chronological ordering per major release". All 0.9.* releases would be together in chronological orders, followed by all 0.10.* releases, etc.

Contributor

harding commented Jan 20, 2015

@saivann makes sense. Thanks!

saivann added a commit that referenced this pull request Jan 21, 2015

Merge pull request #714 from bitcoin/versionint
Order release history and set latest version using versions number instead of releases date

@saivann saivann merged commit c308aaa into master Jan 21, 2015

@saivann saivann deleted the versionint branch Jan 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment