Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Logo SVG optimisation #726

Merged
merged 1 commit into from Feb 2, 2015

Conversation

Projects
None yet
3 participants
Contributor

louisjc commented Feb 1, 2015

I opened the svg file of the logo and I think it deserves some optimizations : I removed useless groups, ids and tags. The result looks identical but the new file is two time smaller.

Also the xml refers to the Creative Commons license while the file is under MIT.

Logo SVG optimisation
Optimisation of the logo svg : remove useless groups and tags.
Contributor

saivann commented Feb 1, 2015

@louisjc Is there a way to optimize these SVG automatically? I guess most if not all SVGs on bitcoin.org would deserve such optimizations... Thanks for opening this pull request!

Contributor

harding commented Feb 1, 2015

@saivann for the record, I tried using scour a few months ago on some of our dev docs SVGs, but the results weren't consistently good like the optipng results.

Contributor

louisjc commented Feb 1, 2015

@saivann The goal is to group transformations together, remove inkscapes tags and ids (both unnecessary here), while keeping numbers untouched to not affect the quality. I know this javascript tool does it (it does not affect quality but some optimization need to be done by hand) maybe the Python version (never used this one) could do the whole folder at a time.

I'm going to check it later.

Contributor

saivann commented Feb 1, 2015

@harding @louisjc Thanks!

This pull request renders fine on all browsers I have tested. In the absence of critical feedback, this pull request will be merged on February 2th.

Contributor

harding commented Feb 2, 2015

@louisjc the 0.10 branch shouldn't be merged into this commit, as Bitcoin Core 0.10 hasn't been released yet. Can you please rebase-remove that merge? (If you don't know how, let me know and I'll provide instructions.) Thanks.

Contributor

louisjc commented Feb 2, 2015

@harding Fixed, it was unintentional.

@saivann saivann merged commit a5bde04 into bitcoin-dot-org:master Feb 2, 2015

Contributor

saivann commented Feb 2, 2015

@louisjc @harding Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment