Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add Coinprism to the wallet list #731
Conversation
harding
added
the
Wallets
label
Feb 4, 2015
Flavien
added some commits
Feb 4, 2015
harding
added
the
Help Needed
label
Feb 27, 2015
Flavien
commented
Apr 3, 2015
|
Any update on the review? |
|
@Flavien we're still heavily backlogged on reviews, but there is now a volunteer working on it. We'll let you know if there's anything we need from you. Thanks for your patience. |
harding
removed
the
Help Needed
label
Apr 12, 2015
harding
self-assigned this
May 7, 2015
|
@Flavien thank you for your patience; we've begun reviewing Coinprism. If I understand correctly, Coinprism reuses the same address over and over, even sending change back to it. This seems to be not only the default behavior, but also something that the user can't disable. (Please let me know if I misunderstand.) We don't want to promote any wallets that encourage address use. This is currently a soft requirement for the site, but we're almost certainly going to make it a hard requirement when Multibit HD is released in a few weeks. How do you feel about us putting our review on hold until Coinprism upgrades to not reuse addresses by default? Thank you again, and sorry about the wait. |
Flavien commentedFeb 4, 2015
This pull request adds the Coinprism Android mobile wallet to the list of wallets.