Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Wallets: Re-Add Circle.com To The Wallet Page #732

Merged
merged 1 commit into from Feb 6, 2015

Conversation

Projects
None yet
4 participants
Contributor

harding commented Feb 4, 2015

Opened at the request of @ywecur in pull #700, this pull request re-adds Circle.com to the wallets page with the same content it had previously.

Circle was removed because it did not implement HSTS, but it does now:

$ curl -s -D- https://circle.com/ | grep Strict
Strict-Transport-Security: max-age=15552000

@harding harding added the Wallets label Feb 4, 2015

Contributor

saivann commented Feb 4, 2015

LGTM. In the absence of critical feedback, this pull request will be merged on February 6th.

Contributor

ywecur commented Feb 4, 2015

Thank you @harding , I much appreciate your help!

Contributor

luke-jr commented Feb 5, 2015

I thought Circle didn't want to be on bitcoin.org? Are they okay with this?

Contributor

harding commented Feb 5, 2015

@luke-jr according to @saivann in this comment:

OK some quick update; apparently if some people really want to add Circle, the contacts I've talked to don't seem to have any serious issue either way.

@saivann saivann merged commit 838457b into bitcoin-dot-org:master Feb 6, 2015

@harding harding deleted the harding:re-add-circle branch Feb 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment