Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Added CoinJar as a web wallet resource. #737
Conversation
harding
added
the
Wallets
label
Feb 7, 2015
shibacomputer
commented
Feb 10, 2015
|
Hi all, any progress on this? |
|
@helveticade I haven't had a chance to perform a review yet, but I just took a quick look. One blocking issue is that CoinJar doesn't seem to support HSTS for its servers. You can see this for yourself by clicking on one of the results from this page, scrolling to the Protocol Details section, and looking at the item named "Strict Transport Security (HSTS)". For CoinJar's servers, it says, "No". According to our policy, "websites serving executable code or requiring authentication must use HSTS with a max-age of at least 180 days." Are you able to ask CoinJar to enable HSTS on their servers? Based on some of the other features they use on their servers, I don't think it would be complicated for them. |
|
@helveticade oh, I forgot to say: thanks for submitting this wallet proposal! |
|
For the record, the current CEO of Coinjar (Zhou Tong) was previously the CEO of bitcoinica, a service that suffered significant failures. So I wasn't sure if Coinjar could be added as per this requirement:
However, unless I'm mistaken somewhere or someone disagrees, I think the following facts could be enough to say Coinjar could pass (or eventually pass) this requirement (note: I haven't reviewed other requirements).
[1] https://bitcoinmagazine.com/1805/bitcoinica-stolen-from-again/ |
harding
added
the
Help Needed
label
Feb 27, 2015
shibacomputer
commented
Mar 31, 2015
|
Sorry it's taken a while to get back to you about this. CoinJar is in the process of implementing HSTS and stronger password policies. @saivann, you're right to be concerned about the questions re: Ryan Zhou's past. The three points you mention are well reasoned. If I can add to this – Ryan is a co-founder but is not the CEO, and shares the responsibilities of the company with others. You guys rock for your diligence here, btw. I'll post an update when HSTS is implemented. |
harding
removed
the
Help Needed
label
Apr 12, 2015
harding
added
the
Need more info
label
May 4, 2015
shibacomputer
commented
May 12, 2015
|
Hi all! CoinJar has updated with HSTS support and stronger password policies! Are we able to merge this PR now or do you need more info? |
harding
removed
the
Need more info
label
May 12, 2015
|
@helveticade no one is currently available to review CoinJar. (Sorry.) I'm going to tag this as help needed until someone is available. Thanks for your patience. |
shibacomputer commentedFeb 6, 2015
Pretty straightforward! Added appropriate information as directed.