/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Updated bitcoin market cap (date and value) #759

Closed
wants to merge 4 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@merland @harding
@merland
Contributor

merland commented Feb 20, 2015

No description provided.

merland added some commits Feb 19, 2015

@merland
Grammar fix. 'As many of them' needs an 'as' part to be complete, but… 
… 'any amount' is more simple and clear, I think.
c6f911e
@merland
merge
8452723
@merland
Merge branch 'master' of https://github.com/bitcoin/bitcoin.org 
* 'master' of https://github.com/bitcoin/bitcoin.org:
  Grammar fix. 'As many of them' needs an 'as' part to be complete, but 'any amount' is more simple and clear, I think.
  Dev Docs: Fix a->an typo (thanks Saïvann!)
  Dev Docs: Add Section About Headers-First IBD
94ddd41
@merland
updated Bitcoin market cap
b5f7b95
@harding
Contributor

harding commented Feb 21, 2015

Hi, @merland. Thanks for all the text updates lately! I have two comments here:

  1. If you have the time, could rephrase that entire sentence to make it less specific (and remove the date entirely) so we won't need to update it in the future? That would help save the translators a lot of time (we have about 25 translations that need to be updated each time a string changes).
  2. It looks like your repository's master branch has fallen out of sync with our master branch, which is what is creating the extra commits shown above. This isn't a major problem for now---I can always cherry-pick your important commits---but you may want to read this StackOverflow page about updating your master branch.

Thanks again!
@merland
Contributor

merland commented Feb 21, 2015

Thanks for the feedback. I am well aware of the the problem with the translations, good idea about rephrasing to something more persistant. I'll give it a try.
Yes, I did manage to mess up something about my repo.... I'll do my homework till next time!
Thanks for your work.

@merland merland closed this Feb 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment