Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Releases: Variablize Release Notes #764
Conversation
harding
added some commits
Feb 23, 2015
saivann
commented on the diff
Feb 24, 2015
README.md
| -... | ||
| -``` | ||
| -* `VERSION` is used to define the version and construct the URL. It should adhere to this format: `v0.3.24`. | ||
| -* `title: ...` will be used as the title. | ||
| -* `magnetlink: ...` (optional) the urlencoded torrent magnet link on the download page. | ||
| +Download links will automatical be set to the defaults using the current |
|
|
|
@harding LGTM! I've quickly tested the result and reviewed the code. |
|
@saivann thanks! (I'll fix that typo.) In the absence of critical feedback, this will be merged around 01:00 UTC Friday. |
harding
added a commit
that referenced
this pull request
Feb 27, 2015
harding
closed this
Feb 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
harding commentedFeb 23, 2015
HTML site diff (English only): http://dg2.dtrt.org/diff.html
This is a re-do of pull #751 that only implements the parts @saivann and I could both agree on per this comment.
It adds additional variables to the release note files to allow setting the version number and date. The version number is required, and can be used to automatically set the release notes title. The date is optional and can be set hours/days after the release.
Additionally, a Makefile test is added that checks whether the download files exist on the Bitcoin.org server. This can help prevent creating a broken Download page.
Changes in commit 404af8b
Changes in commit b88f6ee
Renamed the old release files: