Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Small change: make Getting started more dense #783

Merged
merged 1 commit into from Mar 19, 2015

Conversation

Projects
None yet
3 participants
Contributor

louisjc commented Mar 1, 2015

Just a very small change, I've reduced the margin on the Getting started page. This make the page a bit denser, useful for mobile and small screens.

Contributor

saivann commented Mar 1, 2015

@louisjc Can you apply this to the mobile layout only perhaps, to keep the desktop layout aerated? At the end of the CSS file you can file the rules applied to the mobile layout.

Contributor

louisjc commented Mar 3, 2015

Don't you think this is an improvement for both mobile and desktops? My window size did make a perfect argument for it :

margin

Contributor

saivann commented Mar 3, 2015

@louisjc Mmh, to be honest I think the existing margins are better on desktop, insofar as keeping things areated seems to be the usual watchword for modern designs. However my main issue is with the lack of margin between the "How to use Bitcoin" and "How to accept Bitcoin" subsections of the page.

Contributor

louisjc commented Mar 3, 2015

Didn't saw you want to keep it aerated (I read unaltered for some reason), i think this is a good point you're right! I think I should close it then.

While I'm in the small layout changes, is there a reason why none of the images are center (I think about this page and the faq), I was going to open a pull about it but I would like to hear your opinion before.

Contributor

harding commented Mar 3, 2015

@louisjc I like the idea of centering images. I've wanted that before for the dev docs.

I don't want to impose, but if you're looking for a project, another thing I'd like to see done is have all of the clickable links on the site use the same blue color (including the small boxes like Read More on the getting started page), and then make sure we don't use a similar blue color for anything else (like subheads).

I'm no UI expert, but I think having a single color for all links is recommended.

Contributor

saivann commented Mar 3, 2015

@louisjc Personally I think your changes are an improvement for the mobile layout! In case you want to apply it only to mobiles :) . Thanks for your work on this. Centering pictures is generally fine with me!

Contributor

louisjc commented Mar 6, 2015

@saivann Sorry for the delay, I've moved the change to the mobile section :)
Edit : + My text editor apparently removed 2 useless tab

Contributor

harding commented Mar 6, 2015

@louisjc looks good to me, thanks! I'll merge this in the next time I do a merge.

@harding harding self-assigned this Mar 15, 2015

@harding harding merged commit 6681e4a into bitcoin-dot-org:master Mar 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

harding added a commit that referenced this pull request Mar 19, 2015

Merge pulls #783, #788, Addr fix
* #783: make 'Getting Started' more dense
* #788: fix typo on timereceived
* Addr fix: fix addr mislink reported by larshesel (thanks!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment