/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't remove mobile menu on click #805

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@buren @saivann @harding
@buren
Contributor

buren commented Apr 7, 2015

On mobile, or small viewports, the dropdown menu button is removed on click. It seems like it was intentional, but to me it seems a bit weird and non-standard. Is there any particular reason it works that way? I'm I missing something?

Screenshot - Expanded menu

bitcoin-expanded-mobile-nav

@buren buren changed the title from Don't remove mobile menu onclick to Don't remove mobile menu on click Apr 7, 2015

@saivann
Contributor

saivann commented Apr 7, 2015

LGTM. However I suggest this to be merged when 0.10.1 is released, since this change will trigger an alert for changing javascript on the download page.
@harding
Contributor

harding commented Apr 7, 2015

I'll merge it into my 0.10.1 update branch, which I have to update today anyway. That'll automatically add it to the site/close this PR when 0.10.1 is released. Thanks @buren and @saivann!

@harding harding self-assigned this Apr 7, 2015

@saivann
Contributor

saivann commented Apr 7, 2015

@harding Thanks!
@buren
Contributor

buren commented Apr 7, 2015

@harding thanks! When do you plan release 0.10.1? I'm seeing a rather funny bug on Chrome (OSX 10.10) which causes the mobile menubar to be displayed under the navbar, see the #808. I'm gonna give it a try to see if I can fix it :)
@harding
Contributor

harding commented Apr 7, 2015

It's up to the Bitcoin Core devs to decide when 0.10.1 gets released, but I'd guess within the next 30 days if everything goes well. If your fix arrives after that, we'll probably just hold on to it for a bit to see if we can bundle it with another non-trivial update.

Note that we only try to clump together Javascript updates affecting the Download page. That's because we have special security monitoring for that page. But that doesn't apply elsewhere on the site: if you just fix some CSS or non-Download-page HTML, we'll merge that change as soon as we give everyone a chance to review it.
@buren
Contributor

buren commented Apr 7, 2015

@harding, thanks good to know.

(fixed the chrome issue in #809)

harding added a commit that referenced this pull request Apr 7, 2015

@buren @harding
Site-wide JS: Don't remove mobile menu onclick 
Rebased-from: 979eef6
Rebased-by: David A. Harding <dave@dtrt.org>
Closes #805
This commit was signed with a verified signature.
@harding harding David A. Harding
GPG key ID: 4B29C30FF29EC4B7 Learn about signing commits

All checks have failed

2 failing checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
continuous-integration/travis-ci/push — The Travis CI build failed
Details
5561165

@harding harding referenced this pull request Apr 7, 2015

Merged

Releases: Add Bitcoin Core 0.10.1 #799

4 of 4 tasks complete

@harding harding removed their assignment Apr 7, 2015

harding added a commit to harding/bitcoin.org that referenced this pull request Apr 10, 2015

@buren @harding
Site-wide JS: Don't remove mobile menu onclick 
Rebased-from: 979eef6
Rebased-by: David A. Harding <dave@dtrt.org>
Closes #805
35139af

harding added a commit that referenced this pull request Apr 14, 2015

@buren @harding
Site-wide JS: Don't remove mobile menu onclick 
Rebased-from: 979eef6
Rebased-by: David A. Harding <dave@dtrt.org>
Closes #805
0b0fe6f

@harding harding closed this in 9d9247e Apr 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment