Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Missing address for events causes build script to fail #807
Conversation
|
@buren A side effect of publishing events without address is that the pin on the map becomes inaccurate and, although this might need verification, events without clear venue seem to be cancelled more often. The whole idea of publishing an event with incomplete data seemed a bit odd to me. Maybe I'm wrong though and perhaps there is more good sides of being more permissive. I do think however that it might be more appropriate to not add a pin on the map when it's not going to point to the right location. |
|
I can definitely agree :) Closing. |
buren commentedApr 7, 2015
_events.yml:L76-79
does not define any address and raises an error on this line: events.rb#L106
I think the simplest solution would to be to make the address optional and let google place a generic pin based of
data['city'],data['country']therefore this PR.What do you think?👀