/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes the position of the nav icon when resizeing the window on Chrome #809

Merged
merged 1 commit into from Apr 7, 2015

Conversation

Reviewers
No reviews
Assignees

@harding harding

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@buren @saivann @harding
@buren
Contributor

buren commented Apr 7, 2015

This fixes #808 for some reason, must be a bug in chrome.. Tested the change on safari and firefox and then still render it fine. I'm a bit frustrated that I have no clue why this fixes the issue in chrome :)

@saivann

@buren buren referenced this pull request Apr 7, 2015

Closed

Don't remove mobile menu on click #805

@saivann
Contributor

saivann commented Apr 7, 2015

Strange indeed. LGTM, thanks!
@harding
Contributor

harding commented Apr 7, 2015

@saivann that change to the base template will trigger the download-page-changed alert, right? So I should combine it with the 0.10.1 update?
@saivann
Contributor

saivann commented Apr 7, 2015

@harding The check is not this strict, so AFAIK you can merge it whenever you want. The alerts will be triggered by changes in more sensitive elements only, such as javascript code, links, specific filetypes, etc.
@harding
Contributor

harding commented Apr 7, 2015

@saivann oh, right. I'll merge it in a couple hours with the rest of my updates. Thanks!

@harding harding self-assigned this Apr 7, 2015

@harding harding merged commit fca8456 into bitcoin-dot-org:master Apr 7, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

harding added a commit that referenced this pull request Apr 7, 2015

@harding
Merge pulls #802, #809, and #810 
* 802: Advapay payments event with Armory presenting
* 809: Fixes the position of the nav icon when resizeing the
  window on Chrome
* 810: Style fix on dev docs page
This commit was signed with a verified signature.
@harding harding David A. Harding
GPG key ID: 4B29C30FF29EC4B7 Learn about signing commits
3dd445c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment