/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Stylefix on dev docs page #810

Merged
merged 1 commit into from Apr 7, 2015
+1 −0

Conversation

Reviewers
No reviews
Assignees

@harding harding

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@buren @harding
@buren
Contributor

buren commented Apr 7, 2015

https://bitcoin.org/en/developer-documentation the links with icons looks broken on tablets/large phones.

Before

brokenstyle

After

displayinline
@buren
Contributor

buren commented Apr 7, 2015

I'm sorry if I come across as spammy. Do you prefer each separate change, however small, to be in its own PR or should I group of these kind of smaller changes together?
@harding
Contributor

harding commented Apr 7, 2015

@buren I quickly tested this change and it looked fine to me. I'll test it a bit more throughly and, if there are no problems, merge it.

Regarding grouping changes, what you've been doing is perfect so far. The official policy is to try to make it as easy as possible to review the changes, so related changes should be grouped together and unrelated changes should be separated apart irrespective of the actual size of the change.
@harding
Contributor

harding commented Apr 7, 2015

@buren oh, and thanks for all of your work!

@harding harding self-assigned this Apr 7, 2015

@harding harding merged commit 303a8b7 into bitcoin-dot-org:master Apr 7, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

harding added a commit that referenced this pull request Apr 7, 2015

@harding
Merge pulls #802, #809, and #810 
* 802: Advapay payments event with Armory presenting
* 809: Fixes the position of the nav icon when resizeing the
  window on Chrome
* 810: Style fix on dev docs page
This commit was signed with a verified signature.
@harding harding David A. Harding
GPG key ID: 4B29C30FF29EC4B7 Learn about signing commits
3dd445c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment