Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Skip htmlproofer when partially building the website #818

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

saivann commented Apr 10, 2015

This little change allows me to benefit from other Makefile tests by getting meaningful build failures when doing partial builds. I guess HTMLProofer cannot do much in this specific case, as having missing pages and broken links is an expected outcome of doing a partial build.

(Note: If we later choose to go as far as to validate HTML, we could easily tell HTMLProofer to only do HTML validation and skip link checks)

Contributor

harding commented Apr 10, 2015

@saivann I don't have any problem with this approach, but I've been doing my quick builds using make valid which runs all of the fast tests so you get instant feedback, but doesn't run any of the slow tests like HTML proofer and the test to download the HTTP headers for the Bitcoin Core binaries. This is documented here.

I do think make valid might need some updating after the Glossary PR gets merged, as it reports some missing links if the glossary plugin is disabled, but I'll fix that when I merge _autocrossref.yml and _includes/references.md into _config.yml. (In the meantime, we can just use make -i valid to prevent make from stopping after an error.)

Contributor

saivann commented Apr 10, 2015

@harding Ah, right. I should have looked at the Makefile more carefully. Thanks!

@saivann saivann closed this Apr 10, 2015

@saivann saivann deleted the htmlprooferpartial branch Apr 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment