Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Fix endless loop bug in build scripts #820
Conversation
|
LGTM. Thanks, @saivann! |
saivann
merged commit 6364f99
into
master
Apr 11, 2015
saivann
deleted the
endlessloop branch
Apr 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
saivann commentedApr 11, 2015
The subshell used in the script was used to prevent it from building if another concurrent build starts, but it had the unintended consequence of creating an endless loop when the build script fails.
This pull request allows the script to terminate correctly.
Additionally this pull request enables the quick Makefile tests to catch issues in order to prevent the server to push any broken update (as we've already planned to do, it currently works fine on the build machine according to my testing).