Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bitcoin.pdf: Add A Page That Lists Translations #839

Merged
merged 2 commits into from Apr 25, 2015

Conversation

Projects
None yet
3 participants
Contributor

harding commented Apr 23, 2015

Preview: http://dg2.dtrt.org/en/bitcoin-paper

This PR adds a new page to the site listing the original Bitcoin paper as well as all translations available on Bitcoin.org. The PR also updates all existing direct links to the PDF to point to the new page so readers can discover what translations are available.

Note: this PR isn't complete yet---it requires @breathingdog's Spanish translation to be added
once the issues in #822 are resolved. I'll rebase when that's available.

Contributor

harding commented Apr 23, 2015

@breathingdog if you can provide a Spanish translation for the following text, I'll add it directly to the PR so it doesn't need to wait for our next Spanish update from Transifex:

summary: "The paper that first introduced Bitcoin"
description: "Satoshi Nakamoto's original paper is still recommended reading for anyone studying how Bitcoin works. Choose which translation of the paper you want to read:"
translated_by: "translated by"
submit_new_translation: 'Do you want to translate the paper into your language? Visit the <a href="https://github.com/saivann/bitcoinwhitepaper">Bitcoin Paper repository</a> for instructions and <a href="https://github.com/saivann/bitcoinwhitepaper/issues/new">open an issue</a> if you have any questions.'

I could do a fast translation but always remembering I'm not a pro. The terms "translated_by" or "submit_new_translation" are commands? I suppose they shouldn't be translated, am I wrong?

Contributor

harding commented Apr 24, 2015

@breathingdog if you want to leave the translation for the translators on Transifex, that's perfectly fine. The terms before the first colon are keys, so they don't get translated.

summary: "El documento que presentó por primera vez Bitcoin "
decription: "El documento original de Satoshi continúa siendo lectura recomendada para cualquiera que estudie cómo funciona Bitcoin. Escoge qué traducción del documento quieres leer:"
translated_by: "traducido por"
submit_new_translation: "¿Quieres traducir el documento a tu lengua? Para consultar las instrucciones, visita Bitcoin Paper repository y si tienes preguntas, visita: open an issue"

About the last line, it could be also this way, adding "el" before the link to the repository:

"¿Quieres traducir el documento a tu lengua? Para consultar las instrucciones, visita el Bitcoin Paper repository y si tienes preguntas, visita: open an issue"

Contributor

harding commented Apr 24, 2015

@breathingdog thanks! I updated the PR and the preview:

@saivann saivann commented on an outdated diff Apr 24, 2015

_plugins/translate.rb
@@ -87,6 +87,12 @@ def render(context)
text.gsub!("#"+key+"#",'/'+lang+'/'+CGI::escape(value))
end
end
+
+ ## Hack for renaming links to the Bitcoin paper. Safe to remove
+ ## when all langugages have "bitcoin-paper:" defined in the "url:"
@saivann

saivann Apr 24, 2015

Contributor

@harding s/langugages/languages/

Contributor

saivann commented Apr 24, 2015

@harding I suggest we use a single consistent directory for PDF documents, so either we keep them all at the root of the filesystem (/), or we move them all to /files/bitcoin-whitepaper/ , and only keep a copy of the original English whitepaper at the root of the filesystem given how much backlinks this paper currently has.

harding added some commits Apr 24, 2015

Move Translated Bitcoin.pdf Files
Move translated bitcoin.pdf files to /files/bitcoin-paper
Bitcoin.pdf: Create Page Linking To Translations
- Adds a new page linking to all translations of Nakamoto's Bitcoin
  paper, and also provides instructions for adding new translations

- Changes all links on the site that used to point directly to the
  English bitcoin.pdf to point to the new page.

- Add Spanish Translation by Breathingdog, as well as Spanish strings
  for the now page also by Breathingdog
Contributor

harding commented Apr 24, 2015

Several updates suggested by @saivann (thanks!):

The preview has been updated.

Contributor

saivann commented Apr 24, 2015

@harding Thanks!

Contributor

harding commented Apr 24, 2015

In the absence of critical feedback, I'll merge this PR around 23:00 UTC Saturday.

@harding harding merged commit d383940 into bitcoin-dot-org:master Apr 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

harding added a commit that referenced this pull request Apr 25, 2015

Merge pulls #839 and #840
* 839: Dev Docs Glossary: Add Denominations Entry
* 840: Bitcoin.pdf: Add A Page That Lists Translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment