Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
QA: Fix 16,591 HTML Validation Errors #842
Conversation
saivann
commented on the diff
Apr 27, 2015
| @@ -57,7 +57,7 @@ <h2 id="irc"><img src="/img/icons/ico_help.svg" class="titleicon" alt="Icon">{% | ||
| </div> | ||
| </div> | ||
| -<h2 id="nonprofit"><a name="{% translate non-profit anchor.community %}">{% translate nonprofit %}</a></h2> | ||
| +<h2 id="nonprofit-organizations"><a name="{% translate non-profit anchor.community %}">{% translate nonprofit %}</a></h2> |
saivann
Contributor
|
saivann
commented on an outdated diff
Apr 27, 2015
| @@ -563,7 +563,7 @@ bg: | ||
| donation: "Направете дарение" | ||
| donationtxt: "Най-лесният начин да помогнете е като <a href=\"https://bitcoinfoundation.org/about/donate/\">дарите</a> малко биткойни на Фондация Биткойн. Също така може директно да финансирате проекти, свързани с Биткойн, които смятате, че ще са от полза в бъдещето." | ||
| nonprofit: "Неправителствени организации" | ||
| - nonprofittxt: "Bitcoin фондация< /a> и много други организации с нестопанска цел< /a> са посветени на защитата и насърчаването Bitcoin. Можете да се помогне на тези групи от присъединяване към тях и участие в проектите им, дискусии и Събития." | ||
| + nonprofittxt: "Bitcoin фондация и много други организации с нестопанска цел са посветени на защитата и насърчаването Bitcoin. Можете да се помогне на тези групи от присъединяване към тях и участие в проектите им, дискусии и Събития." |
saivann
Contributor
|
saivann
and 1 other
commented on an outdated diff
Apr 27, 2015
| @@ -8,7 +8,7 @@ | ||
| title: Bitcoin | ||
| --- | ||
| <p class="mainsummary">{% translate listintro %}</p> | ||
| -<div class="mainvideo"><iframe src="//www.youtube.com/embed/Gc2en3nHxA4?rel=0&showinfo=0&wmode=opaque{% if page.lang != 'en' %}&cc_load_policy=1&hl={{ page.lang }}&cc_lang_pref={{ page.lang }}{% endif %}" frameborder="0" allowfullscreen></iframe></div> | ||
| +<div class="mainvideo"><iframe src="//www.youtube.com/embed/Gc2en3nHxA4?rel=0&showinfo=0&wmode=opaque{% if page.lang != 'en' %}&cc_load_policy=1&hl={{ page.lang }}&cc_lang_pref={{ page.lang }}{% endif %}" frameborder="0" allowfullscreen></iframe></div> |
saivann
Contributor
|
|
@harding This is fantastic, thank you so much! Will you take care to make the same modifications upstream on Transifex for each translations too? |
harding
added some commits
Apr 26, 2015
|
Rebased on current master to make sure everything still checked out with the 0.10.1 release (it did) and added commit 593a56d to fix the two regressions @saivann identified. (Thanks!) @saivann I wasn't planning to mess with Transifex. I find the Bitcoin.org/Transifex interface frustrating and I haven't yet put any time into working on it. If you think that's a blocker for merging this, let me know. Otherwise, in the absence of critical feedback, I'll merge this around 13:00 UTC Tuesday. |
harding
merged commit 593a56d
into
bitcoin-dot-org:master
Apr 28, 2015
1 check passed
harding
added a commit
that referenced
this pull request
Apr 28, 2015
|
@harding I just updated translations by hand on Transifex, and will take care of updating en.yml as well. |
|
@saivann wow, thanks! |
harding commentedApr 26, 2015
Preview: http://dg2.dtrt.org/
This PR:
Despite the attention-grabbing title, less than a dozen of those errors actually had any affect on the page rendered in Firefox thanks to the forgiving nature of modern browsers.
For details on why various changes were made, please read the commit notes.
I've checked many of the modified link/image/iframe URLs, as well as previewed all of the altered English pages and some of the non-English pages. The altered Bitcoin Core magnet link works in Transmission GUI for Linux.