Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Separate event script from event data #849
Conversation
|
@saivann do you need me to do something similar with https://github.com/bitcoin/bitcoin.org/blob/master/js/devsearch.js ? |
|
@harding Thanks for asking. I think it's always a good practice to keep data outside of scripts, but the devsearch.js script is way less of an issue compared to the event page. The later receives automatic unimportant modifications many times a week. |
|
Tested LGTM. @saivann extra thanks for adding the "this file is built non-deterministically" back in! :-) |
|
@harding Thanks for the careful testing and deterministic monitoring on the website :) In the absence of critical feedback, this pull request will be merged on May 2th. |
saivann commentedMay 1, 2015
When monitoring sensitive changes on the website, regular script changes on all event pages are generating unhelpful non-descriptive noise, which might grab my attention away from real suspicious script changes.
This change renders events links and data directly on the page (inside an hidden DIV) and lets the script grab required data from there instead.