Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Separate event script from event data #849

Merged
merged 1 commit into from May 2, 2015

Conversation

Projects
None yet
2 participants
Contributor

saivann commented May 1, 2015

When monitoring sensitive changes on the website, regular script changes on all event pages are generating unhelpful non-descriptive noise, which might grab my attention away from real suspicious script changes.

This change renders events links and data directly on the page (inside an hidden DIV) and lets the script grab required data from there instead.

Contributor

harding commented May 1, 2015

Contributor

saivann commented May 1, 2015

@harding Thanks for asking. I think it's always a good practice to keep data outside of scripts, but the devsearch.js script is way less of an issue compared to the event page. The later receives automatic unimportant modifications many times a week.

Contributor

harding commented May 1, 2015

Tested LGTM. @saivann extra thanks for adding the "this file is built non-deterministically" back in! :-)

Contributor

saivann commented May 2, 2015

@harding Thanks for the careful testing and deterministic monitoring on the website :)

In the absence of critical feedback, this pull request will be merged on May 2th.

@saivann saivann merged commit 262b550 into master May 2, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@saivann saivann deleted the eventdata branch May 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment