Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Backend: Update Kramdown Version #869

Merged
merged 1 commit into from Jun 3, 2015

Conversation

Projects
None yet
2 participants
Contributor

harding commented May 30, 2015

Updates to a newer version of Kramdown, the library used to convert Markdown to HTML. A diff of the generated website using the previous version to the new version is available here. There are only two changes that I see:

  1. Automatically-generated table of contents for the various dev docs now have an id attribute assigned to each list item. Every id starts with markdown-toc- so I doubt there are any conflicts with previous ids and I don't see any issues.
  2. In plain-text paragraphs and list items converted to HTML by Kramdown, trailing whitespace is now removed. I confirmed this does not apply to anything inside pre tags. I also confirmed that it only applies to trailing whitespace.

Not visible is that the old version of Kramdown has problems with HTML <button>, which I ran into while working on a separate branch. This update to the newer version fixes that.

Note: when merged, this PR will be the first test of the new automatic library upgrade feature on the build server. I'll be standing by to fix any problems. @saivann and anyone else who has previously built the website locally will need to run bundle install from their local repository directory to install the newer version of Kramdown.

Backend: Update Kramdown Version
Use a newer version of Kramdown to workaround a parsing bug.
Contributor

saivann commented May 31, 2015

Untested LGTM, thanks!

@harding harding merged commit ace49c8 into bitcoin-dot-org:master Jun 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Contributor

harding commented Jun 3, 2015

Post-merge note: I verified that the site built correctly with the updated library. There was no problem with the update mechanism.

Contributor

saivann commented Jun 3, 2015

Thanks!
Le 3 juin 2015 14:00, "David A. Harding" notifications@github.com a
écrit :

Post-merge note: I verified that the site built correctly with the updated
library. There was no problem with the update mechanism.


Reply to this email directly or view it on GitHub
bitcoin#869 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment