Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Backend: Update Kramdown Version #869
Conversation
|
Untested LGTM, thanks! |
harding
merged commit ace49c8
into
bitcoin-dot-org:master
Jun 3, 2015
1 check passed
|
Post-merge note: I verified that the site built correctly with the updated library. There was no problem with the update mechanism. |
|
Thanks!
|
harding commentedMay 30, 2015
Updates to a newer version of Kramdown, the library used to convert Markdown to HTML. A diff of the generated website using the previous version to the new version is available here. There are only two changes that I see:
markdown-toc-so I doubt there are any conflicts with previous ids and I don't see any issues.Not visible is that the old version of Kramdown has problems with HTML
<button>, which I ran into while working on a separate branch. This update to the newer version fixes that.Note: when merged, this PR will be the first test of the new automatic library upgrade feature on the build server. I'll be standing by to fix any problems. @saivann and anyone else who has previously built the website locally will need to run
bundle installfrom their local repository directory to install the newer version of Kramdown.