Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Support blank spaces in file names when generating sha256sums.txt #871
Conversation
|
Untested LGTM. Thanks! |
saivann
merged commit 4cb4e7e
into
master
Jun 2, 2015
saivann
deleted the
blankspaces branch
Jun 2, 2015
|
@harding I just tested the change to make sure the resulting sha256sums.txt file was identical. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
saivann commentedJun 2, 2015
This bug was preventing translation live previews to be generated due to blank lines in the urls of some recent translations.
For instance, current unreviewed Spanish translations generate a "_site/es/documento de bitcoin.html" page. With the current Makefile, xargs would search for (and fail to find) "_site/es/documento", "de", and "bitcoin.html".
Such troublesome urls are prevented on the live website using the check-for-non-ascii-urls rules in the Makefile. However, live previews are meant to ignore such mistakes (using only "make build") so all working pages can be built and previewed without interruption.