Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update Mycelium description #902

Merged
merged 2 commits into from Jun 18, 2015

Conversation

Projects
None yet
5 participants
Contributor

saivann commented Jun 16, 2015

As suggested in #896, this pull request updates Mycelium's description, and drops any mention of it being open-source.

In the absence of critical feedback, this pull request will be merged on June 17th.

Contributor

harding commented Jun 16, 2015

@saivann thanks! Except for the comment to Craig below, this LGTM.

@crwatkins I know you had some concerns with another wallet that listed compatibility with hardware wallets that weren't really supported. Do you think this needs investigation before being updated?

Contributor

crwatkins commented Jun 16, 2015

@harding I can personally confirm (from previous testing) that Mycelium on Android is compatible with Trezor. I can further confirm that MultiBit HD with the same Trezor can access the same account as Mycelium with that Trezor. That's compatible in my book. However, I don't believe that I would consider Mycelium compatible with MultiBit HD (without a Trezor). I believe that (without a Trezor) Mycelium uses a BIP44 path of m/44'/0'/0'/c/i while MultiBit HD uses a BIP32 path of m/0'/c/i.

My suggested fix with the least number of words changed would be "... offers compatibilty with Trezor, Multibit HD with Trezor, and others." However, that's still not as clear as it could be. Perhaps @apetersson can confirm this and suggest something that is clearer.

Contributor

harding commented Jun 16, 2015

@crwatkins wow, thanks! Let's see what @apetersson says.

jim618 commented Jun 17, 2015

@crwatkins Primarily to cater for the use case of someone losing their Trezor and needing to recover their bitcoins in MultiBit HD with no replacement Trezor we programmed up that the user can create what we call a 'soft' wallet that uses a path of m/44'/0'/0'/c/i.

This is a wallet stored on the desktop computer with all the private keys stored locally and the keys use the Trezor path derivation of m/44'/0'/0'/c/i

It is available in the restore as an option - see screenshot:

screen shot 2015-06-17 at 09 07 22

Thus more technically minded users could restore their Mycelium seed phrase and create the same wallet on MultiBit HD.

We've not created a Wizard for this as we find users (and ourselves !) get confused by the different sorts of HD wallets. We don't want people thinking that a 'Trezor soft wallet' gives the same level of protection as an actual Trezor.

To make it as clear as we can to users we have a section in the Manage Wallet | Wallet dashboard titled 'Wallet capabilities'. This gives a description of the wallet e.g. for standard MultiBit HD wallets it says:

Standard MultiBit HD wallet
Private keys are encrypted on this machine
BIP32 compliant. m/0h (Account 1 only)

tl;dr A Mycelium wallet can be recreated on MultiBit HD if the user really wants to.

Contributor

crwatkins commented Jun 17, 2015

Thanks Jim. Just to be certain, however: A wallet created on MultiBit HD could not be recovered with Mycelium, right?

Contributor

gurnec commented Jun 17, 2015

@crwatkins Apologies for interjecting, but to answer your question: MulitBit HD always creates BIP-32 path wallets, and Mycelium only supports BIP-44 path wallets, so "yes, right".

I should also point out that Mycelium supports multiple BIP-44 accounts (I haven't tested this with a Trezor though), and a BIP-44 wallet imported into MultiBit HD will only see the first account with account index 0, called "Account 1" by Mycelium. Any other accounts are ignored.

If it's of any future use, I try to maintain a spreadsheet here listing deterministic wallet compatibility details, along with compatibility charts between different wallets (and a discussion thread is here on BitcoinTalk).

Contributor

saivann commented Jun 17, 2015

If I understand correctly, MultiBit HD is compatible with Mycelium, but not the other way around. Accordingly, I have dropped MultiBit HD from the description.

@crwatkins @jim618 @gurnec Thanks a lot for the comments.

@gurnec Cool research! Would be great I think if it was published somewhere like the wiki.

Contributor

harding commented Jun 17, 2015

Updated text LGTM. Thanks everyone!

Contributor

saivann commented Jun 17, 2015

In the absence of critical feedback, this pull request will be merged on June 18th.

Contributor

crwatkins commented Jun 17, 2015

Thanks @gurnec

@saivann LGTM

@harding harding merged commit 9411bd0 into master Jun 18, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

harding added a commit that referenced this pull request Jun 18, 2015

Merge PRs #887, #900, #902
- #887: Replacing MultiBit Classic with MultiBit HD
- #900: Community: Add Bitcoin Embasy Amsterdam
- #902: Update Mycelium description

@saivann saivann deleted the myceliumopensource branch Jul 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment