Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Enable gzip compression #917
Conversation
saivann
added some commits
Jun 25, 2015
|
@harding Thanks! In the absence of critical feedback, this pull request will be merged on June 26th. |
saivann
added
the
Merge Scheduled
label
Jun 25, 2015
|
@saivann LGTM, Should save a lot of bandwidth. By the way I didn't find the info: who is paying for this bandwidth and where is it hosted? (EDIT: Also, not the right place to ask, but why did this repo leave the bitcoin github organisation?) |
|
@louisjc the server is hosted by Block Lotus, for which we currently pay $590 a month from the sponsorship money given to us by the Bitcoin Foundation. Details about the repository move can be found in #912, let me know if you have any questions after reading that thread. Thanks again for your suggestion! I think it'll be a major improvement! |
saivann
merged commit 42cef24
into
master
Jun 26, 2015
saivann
deleted the
gzipcompress branch
Jun 26, 2015
saivann
removed
the
Merge Scheduled
label
Jun 26, 2015
|
Gzip compression is now enabled and everything seems to be working fine. Many thanks again for submitting the idea! |
|
@louisjc Great! That'll be especially helpful for HTML and JS content, which have much less aggressive caching policies (if any, I don't recall right away).
Ah, not for long then! See #923 Many thanks again for your insightful suggestions :) |
saivann commentedJun 25, 2015
This pull request adds support for gzip compression in order to increase performance and reduce load on the server (thanks to @louisjc and @harding for the idea on issue #916).
This single line change allows the build script to generate a .gz copy of all files for which compression offers a measurable improvement. This is done right after the website has successfully built, and before transferring files to the live server.
I have tested the build script and nginx locally with the following configuration and everything seemed to work as expected. Only compressed files are sent using gzip as the Content-Encoding header. The website also remains compatible with IE6 as expected.
@harding sha256sums.txt is already generated before files are compressed, so unless I am missing something, it should still work fine with that change.