Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
About-Us: History, Staff Updates, & Signed Commits #918
Conversation
harding
added some commits
Jun 17, 2015
|
@harding I didn't carefully look at the changes yet but I can think of a minor bug; if a build starts and an unsigned commit is pushed in the next 10 minutes, the ongoing build will abort and the most recent commit won't build. This can probably be easily avoided by using this updated code at the end of the script (careful, untested!):
|
|
I don't think git allows multiple people to sign commits? Did I miss something? Concept ACK. |
|
I have submitted a few changes to the script (including the one in my comment above) as a pull request. BTW @Coderwill in case you want to do the same, that often makes things easier. Otherwise, this LGTM up to 3b50ddb. I have verified that the keys in the keyring are either those I already knew and trusted, or otherwise matched public keys from relatively safe sources. I have also been able to test that the keyring is properly used instead of the system's keyring, and that non-existing signatures as well as untrusted signatures both stop the build script, as expected. |
|
@luke-jr to the best of my knowledge, git does not let multiple people sign commits, which is why I only implemented checking for single-signed commits in this first step. If we decide later that we really do need multiple-signed commits, we'll have to look at using git tags or some sort of metadata store. @saivann and @Coderwill I'll begin reviewing your PRs momentarily. Thanks! |
|
@harding Speaking as one of the people who was interested in an expanded "Who owns bitcoin.org" section, I think this is a very nice improvement. Thanks! |
|
Thanks @theymos. |
saivann
added some commits
Jun 26, 2015
|
Updated with @saivann's proposed patches to the build script. In the absence of critical feedback, this pull will be merged on Monday. |
harding
added
the
Merge Scheduled
label
Jun 26, 2015
|
@harding Fantastic, thanks for this great improvement! |
|
I'm going to upgrade the build server now using the code from this, and I'll test that it works by merging some of the minor merges scheduled for today using signed/unsigned merge commits. Once I'm satisfied that it's working correctly, I'll merge this PR. |
harding
merged commit 120030f
into
bitcoin-dot-org:master
Jun 29, 2015
1 check passed
harding
added a commit
that referenced
this pull request
Jun 29, 2015
ABISprotocol
commented
Jul 1, 2015
|
-----BEGIN PGP SIGNED MESSAGE----- I wasn't aware this (multiple-signed commits) might be possible On 06/26/2015 08:13 AM, David A. Harding wrote:
iQEcBAEBAgAGBQJVlG+tAAoJEGxwq/inSG8CWxsH/0Umi1Vmh/V25JiUm/X+BNHR |
harding commentedJun 26, 2015
This PR contains three somewhat related commits:
1—More Bitcoin.org History & Ownership Info
By multiple request, we've expanded the "Who owns bitcoin.org" section to cover more history and more information about who owns Bitcoin.org. Text highlighted in green below is new or substantially revised:
2—Staff Updates
We simplified titles in the Maintainer section:
Along with the title changes, I (@harding) will be focusing more time on documentation and, shortly after this PR is merged, we will be giving Craig (@crwatkins) edit/commit access to help him more efficiently continue his excellent work on the Choose Your Wallet page.
We've also happily been able to move Will (@Coderwill) from the Inactive Contributor section back to the position of Translation Coordinator:
Finally, we've added a section for the domain co-owners who wish to be publicly listed:
3—Signed Commits For Auto-Building
The final commit doesn't affect the site layout at all, but is related to how the site gets updated. The site is currently automatically re-built whenever a new commit is pushed to the repository master branch. Once this PR is merged, that will only be the case if the tip of the commit tree is signed by one of the authorized keys below:
Saïvann and I can still login to the build server and trigger a manual build for unsigned commits, for example when Craig merges a new wallet.
This allows us to extend edit/commit privileges to contributors more easily, and prevents GitHub administrators or hackers from being able to take over the site. As a future upgrade, we may move to requiring all commits be signed by two people, but that's just an idea for now.
(You can verify the keys above are indeed the authorized keys by running
gpg _build/auto-build-committers.gnupg/pubring.gpgon this branch.)