/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Simplify javascript code for expanding lists and blocks #920

Merged
merged 1 commit into from Jun 29, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Merge Scheduled
Projects
None yet
Milestone
No milestone
2 participants
@saivann @harding
@saivann
Contributor

saivann commented Jun 26, 2015

There is currently 4 different javascript functions duplicating code for doing mostly the same thing; animating lists or boxes as they expand on user demand.

This pull request makes some optimizations to simplify and shorten the code, by adopting better practices such as moving styles to CSS stylesheets and using a single function to do the animation.

At the same time, some big blocks of related CSS code used only for IE8's compatibility are moved into a separate file to reduce the load for most browsers and simplify compatibility maintenance.

I have tested the changes with IE8-9-10 and various OP, CH, SA, FF versions.

Live preview: (Merged)

In the absence of critical feedback, this pull request will be merged on June 29th.
@saivann
Simplify javascript code for expanding lists and blocks 
Move styles to CSS stylesheets by using a class
Use a single function for all expanding boxes and lists
Separate CSS code for IE8 compatibility
b27bcaf

@saivann saivann added the Merge Scheduled label Jun 26, 2015

@harding
Contributor

harding commented Jun 28, 2015

Reviewed code and lightly tested. LGTM b27bcaf Thanks!

@saivann saivann merged commit b27bcaf into bitcoin-dot-org:master Jun 29, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@saivann saivann deleted the saivann:jsexpandbox branch Jun 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment