Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use standard proper noun capitalization for Trezor to maintain consistency throughout site. #921

Merged
merged 1 commit into from Jun 28, 2015

Conversation

Projects
None yet
5 participants
Contributor

wbnns commented Jun 26, 2015

pryds, who is coordinating a good bit of the Dutch translation, was asking why TREZOR wasn't in all-caps in the Mycelium Android Wallet description. He/She wasn't sure how it should be cased in the Dutch translation - this PR puts in all caps to consistently match the other mentions on the site.

Contributor

gurnec commented Jun 26, 2015

Just for (brief) discussion—should it be "Trezor" instead? Wikipedia uses the rationale: excluding all-caps trademarks

avoids drawing undue attention to some subjects rather than others [...] even if the trademark owner considers nonstandard [all-caps] formatting "official"

(reference)

I think either way is fine, as long as it's consistent.

Contributor

saivann commented Jun 26, 2015

FWIW, I had the same sentiment when looking at TREZOR vs Ledger Nano. I think doing the same as Wikipedia would make a lot of sense.

Contributor

wbnns commented Jun 26, 2015

@gurnec @saivann - thanks for the feedback - I just swapped it so that it's the other way around, no instances of all caps.

Contributor

saivann commented Jun 26, 2015

@Coderwill There is a remaining all-caps TREZOR in the choose-your-wallet template. A useful trick; you can use "git grep TREZOR" or "grep -r --color TREZOR" to find all occurences of something to make sure you can fix them all.

Contributor

wbnns commented Jun 26, 2015

@saivann Ah thanks, I see it - I was only doing a search inside the strings file.

Contributor

wbnns commented Jun 26, 2015

Updated the two additional references on the Choose Your Wallet page.

Contributor

saivann commented Jun 26, 2015

Commit c9855a8 LGTM, thanks!

I think not allowing uppercase trademarks fits pretty closely with previous pull requests for not allowing superlatives in wallet descriptions.

@harding harding changed the title from Make TREZOR all-caps to maintain consistency throughout site. to Use standard proper noun capitalization for Trezor to maintain consistency throughout site. Jun 26, 2015

Contributor

harding commented Jun 26, 2015

c9855a8 LGTM too, and I strongly approve of the policy of avoiding all-caps when reasonable.

In the absence of critical feedback, this will be merged Saturday.

Contributor

crwatkins commented Jun 26, 2015

LGTM. Kudos to @gurnec for the precedence reference at Wikipedia. I will personally adopt those styles.

Contributor

harding commented Jun 26, 2015

Yeah, the Wikipedia style guide is pretty good for online documentation. It's our fallback for the dev docs:

For all style matters not explicitly covered in this guide, the authority is the Wikipedia Manual Of Style.

@harding harding merged commit c9855a8 into bitcoin-dot-org:master Jun 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

harding added a commit that referenced this pull request Jun 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment