Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Use standard proper noun capitalization for Trezor to maintain consistency throughout site. #921
Conversation
|
Just for (brief) discussion—should it be "Trezor" instead? Wikipedia uses the rationale: excluding all-caps trademarks
I think either way is fine, as long as it's consistent. |
|
FWIW, I had the same sentiment when looking at TREZOR vs Ledger Nano. I think doing the same as Wikipedia would make a lot of sense. |
|
@Coderwill There is a remaining all-caps TREZOR in the choose-your-wallet template. A useful trick; you can use "git grep TREZOR" or "grep -r --color TREZOR" to find all occurences of something to make sure you can fix them all. |
|
@saivann Ah thanks, I see it - I was only doing a search inside the strings file. |
|
Updated the two additional references on the Choose Your Wallet page. |
|
Commit c9855a8 LGTM, thanks! I think not allowing uppercase trademarks fits pretty closely with previous pull requests for not allowing superlatives in wallet descriptions. |
harding
changed the title from
Make TREZOR all-caps to maintain consistency throughout site.
to
Use standard proper noun capitalization for Trezor to maintain consistency throughout site.
Jun 26, 2015
|
c9855a8 LGTM too, and I strongly approve of the policy of avoiding all-caps when reasonable. In the absence of critical feedback, this will be merged Saturday. |
harding
added
the
Merge Scheduled
label
Jun 26, 2015
|
LGTM. Kudos to @gurnec for the precedence reference at Wikipedia. I will personally adopt those styles. |
|
Yeah, the Wikipedia style guide is pretty good for online documentation. It's our fallback for the dev docs:
|
wbnns commentedJun 26, 2015
pryds, who is coordinating a good bit of the Dutch translation, was asking why TREZOR wasn't in all-caps in the Mycelium Android Wallet description. He/She wasn't sure how it should be cased in the Dutch translation - this PR puts in all caps to consistently match the other mentions on the site.