Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
DevDocs: update a mis-directed link and clarify SIGHASH_SINGLE definitions #922
Conversation
harding
added
the
Dev Docs
label
Jun 26, 2015
harding
commented on an outdated diff
Jun 27, 2015
| @@ -7,9 +7,10 @@ required: | ||
| title_max_40_characters_no_formatting: SIGHASH_SINGLE | ||
| summary_max_255_characters_no_formatting: > | ||
| - Signature hash type which only signs its input and the output | ||
| - with the same index value, allowing modification of other inputs | ||
| - and outputs. | ||
| + Signature hash type which signs the output corresponding to this input | ||
| + (the one with the same index value), this input, and any other inputs | ||
| + partially. Allows modification of other outputs. The partial signing of | ||
| + other inputs allows modification of their sequence numbers. |
harding
Contributor
|
|
@harding Thanks for the feedback. I just refined that definition to make it shorter. Glad I could help! |
|
LGTM. Thanks! In the absence of critical feedback, this will be merged Monday. |
harding
added
the
Merge Scheduled
label
Jun 28, 2015
harding
merged commit 8498edf
into
bitcoin-dot-org:master
Jun 29, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
harding
added a commit
that referenced
this pull request
Jun 29, 2015
mruddy
deleted the
unknown repository branch
Jul 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mruddy commentedJun 26, 2015
First, there was a mis-directed link that was going to the SIGHASH_NONE definition page.
Second, the definitions for SIGHASH_SINGLE didn't seem to be consistent with the current code. The definitions at https://en.bitcoin.it/wiki/OP_CHECKSIG seem much closer. The code I'm looking at is https://github.com/bitcoin/bitcoin/blob/bc60b2b4b401f0adff5b8b9678903ff8feb5867b/src/script/interpreter.cpp#L-1024-1101
Hopefully, these definitions are closer to how it actually works.