Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add Wladimir's Releases Key #924
Conversation
|
ACK |
|
LGTM (commit 4d9f830), although wouldn't it be more useful to include both keys into laanwj.asc? There is likely plenty of links pointing to that key, and there is less chances that people might end up confused because they didn't get the right key. We also wouldn't need two PGP keys linked on the development page. |
|
Makes sense. ACK. @saivann one argument to keep the keys separate is that they'll be used for separate purposes: the PGP link with the mail is there mainly to mail privately about security issues, the release key will only sign |
|
@laanwj I'm not sure if you're for or against a single key file by reading your comment? Either way, my main concern is about people who already refer to the existing link, and new users who will read "binaries are signed by Wladimir" and get your public key for that purpose. If we keep two key files, I think it'd be nice to add a commit to link to it from the Development page too (maybe the layout may need some adaptation). |
|
My main reason for keeping them separate was that I assumed they had different security properties, maybe with the code signing key being kept on an offline computer.[1] I thought keeping them separate would help prevent people who only wanted the code signing key from accidentally importing both and, if the regular key becomes compromised, not noticing that a malicious binary was signed by the wrong key. I'm happy to combine them if you want. For listing the code signing keys, we should probably have a list of what versions are signed by which keys. Maybe just a single sentence added to the Development and Download pages? I'll look into that. [1] I do this: my master signing key has never been on an online computer, but the encryption and signing subkeys I use every day are on my regular laptop. In case my laptop is compromised, I can revoke the daily keys while keeping the master key useful. I also use the master signing key for signing things that require the extra strong non-repudiation property. |
|
Added commit 9d351ed which adds the following text to the Download page (highlighted here in green): On mobiles, it looks like: I only checked as far back as 0.8.6 because that's all we have hosted in |
|
Added commit 3a89870 by @saivann which much improves upon my crude attempt at listing keys. Screenshot below: I tested it, and it LGTM. On harding#21 (comment) @saivann also said, "adding links to keys in the download page mostly makes me neutral now regarding my previous suggestion [to combine the keys]." So, if there are no further problems identified and everyone is ok with separate keys, I'll merge on Monday. Thanks everyone! |
harding
added
the
Merge Scheduled
label
Jun 28, 2015
|
@harding Thanks, sounds good! |



harding commentedJun 27, 2015
From this message: