Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add "Remote Node" Wallet Classifications #927
Conversation
maraoz
and others
added some commits
Oct 1, 2014
I believe these additional classifications are relevant for the following wallets:
To fit the classifications, wallets must:
After reviewing each of these wallets, I believe none of the above wallets match these criteria. |
|
@crwatkins @Coderwill @saivann @harding, could I get your feedback on this PR? Thanks! |
|
@bitjson thanks for opening a separate PR! I'm mildly against this. In the past, we've had the policy that we score wallets based on their default settings. This has caused plenty of disagreements before, but it feels like the best choice for our current simple page design and our target audience of new Bitcoin users. This PR seems to score wallets based on what's reasonably possible for a power user to do, not what newbies get from a default installation. Does that make sense? I do note that I think we'd all like to better address configuration options / multiple wallet modes when we next redesign the page, as more and more wallets are like Copay in offering significant extensibility. Thank you again for your active participation on both PRs! (And, by the way, Copay is pretty friggin' awesome.) |
|
Thanks for chiming in.
I agree with this policy.
I'd like to clarify – this PR does not score Copay based on what's possible for a power user to do, it scores the wallet based on it's default settings. If we assumed all users would take advantage of the possibility to self-host the remote node, we could give the wallet a I don't think I made it very clear in the PR description – right now, I think this page is missing an opportunity to promote better security practices. I'd like to fix this by clarifying some wording and improving two descriptions with an additional sentence:
and
These descriptions are not visible until the user first reveals the popup for the wallet, then reveals the popup for the scoring items in question. (So they don't add complexity for new users and will only be seen by those trying to deeply understand the topic.) There are also already 35 descriptions like these (a number of which are only applied to a single wallet), so it seems (and I would agree) that accuracy and promoting security are more valuable to us than maintaining regularity between descriptions. I think it's also worth mentioning again – the existence of these classifications might encourage future wallet developers to consider open-sourcing the remote nodes to which their wallets connect; that would be a very positive step for security in the bitcoin ecosystem. |
|
@harding thank you for keeping this site so well-maintained! |
Indeed it does. I had misunderstood someone else's objection and not looked closely enough to notice that. Sorry. I searched for the word "can" in our current score descriptions and found four that seem to make the kind of suggestions your PR makes:
So I think there's definitely precedence for this kind of text. On the other hand, I'm still hesitant: for every negative score we give, there's probably some possible work around. Should we list them all, list none of them, or list only the ones we think are important? |
|
@harding I think we don't have much choice but to pick what seems to be most relevant advices after outlining a problem in the scores. However, that doesn't always mean the features we're talking about are all directly supported by the wallet (e.g. cold storage, 2FA) I would perfectly understand why one would prefer to put this PR on hold until the page is reworked instead of accumulating scores one over the other. That's nearly becoming too much work. I wouldn't be shocked either if these scores were considered good enough and merged for Copay alone, and eventually applied to other wallets later (and maybe edited to fit more wallets at once) when wallets get re-reviewed or someone suddenly start working on optimizing scores. |
|
I have to agree with @harding in that I'm mildly against this. As I mentioned in a bit more detail in #888 I've recently been reviewing more suggested changes to the scoring system than I have been reviewing wallets themselves, and I just don't think this differentiation is compelling enough at this time (lazy reviewer syndrome). I might find this more compelling if it were easier and more straightforward to invoke the option of running a remote node. Even in the Copay/BWS situation in which the server is very well documented and very well maintained, it still takes significant effort to install development tools, install, run, and maintain a separate database product, install the server, secure it, and run and maintain it. This is all very difficult, at least compared to clicking on a wallet in an app store which is our difficulty baseline here. At this point I pretty much need to be overwhelmed with the need for a change for me to actively recommend it. |
bitjson commentedJul 1, 2015
Edit: 7/1/2015
I think the
choose-your-walletpage is missing an opportunity to promote better security practices. I'd like to fix this by clarifying some wording and improving two descriptions with an additional sentence:and
Please see discussion in #888.
This pull request adds validation and privacy classifications for "remote node" wallet architectures.
Wallets with open-sourced server software and an in-app option to use a user-controlled server would fit these classifications.
This pull request initially marks Copay with the added classifications.
Remote Validation
checkfailvalidationremote(currently displays in yellow)Discloses information to a remote node
checkfailprivacydisclosureremote(currently displays in yellow)