/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Simplify javascript code for wallets #931

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@saivann
@saivann
Contributor

saivann commented Jul 3, 2015

Sorry in advance for these large changes. A lot of code isn't really modified, only reorganized.

Live preview: (Pull request closed)

It appeared to me that the javascript code for wallets was a bit unreadable with confusing function names, so I bundled many functions dedicated for events on the page into two single functions (walletMenuListener and walletListener) with subfunctions (closures) and tried to shorten / improve syntax a bit elsewhere.

This pull request also fixes a bug where the bubble of a wallet would show if the mouse is hovering over the icon after the user clicked within the bubble, as well as fixing a few unintended use of global variables through the code.

I have tested these changes against IE 8-9, FF, SA, CH, OP, Android 2.3.6

In the absence of critical feedback, this pull request will be merged on July 6th.
@saivann
Simplify javascript code for wallets 
Bundle several event listener functions together with a clearer name
Fix a bug where a wallet's bubble would show on mouse over
Shorten or improve syntax in some cases
Fix accidental use of global variables

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
3405d61

@saivann saivann added the Merge Scheduled label Jul 3, 2015

@saivann
Contributor

saivann commented Jul 6, 2015

Quick update; I am waiting for additional feedback from @crwatkins about iPad bugs with click events.

@saivann saivann referenced this pull request Jul 7, 2015

Merged

Rework menus for mobile compatibility #950

@saivann
Contributor

saivann commented Jul 7, 2015

This pull request has been replaced by #950

@saivann saivann closed this Jul 7, 2015

@saivann saivann removed the Merge Scheduled label Jul 7, 2015

@saivann saivann deleted the saivann:jswallet branch Jul 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment