/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Hide wallets on click, not on mouseout #932

Closed
wants to merge 2 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@saivann
@saivann
Contributor

saivann commented Jul 3, 2015

Live preview: (Pull request closed)

This is a change I've noticed on bitcoin.com which I like. I often found that I have trouble navigating between wallets as the mouse easily slips outside of the bubble, which forces to me click on the wallet again to re-open the bubble. Opening and closing that bubble on click seems more consistent and convenient to me (and is actually simplier to implement).

This change keeps compatibility with javascript-disabled browsers, thanks to :hover CSS rules only overriden by javascript when it's enabled.

I have tested this pull request against IE 8-9, FF, SA, CH, OP, Android 2.3.6

Edit: I had to apply the same behavior to the menu following a bug report from @crwatkins

saivann added some commits Jul 3, 2015

@saivann
Hide wallets on click, not on mouseout
d8d6546
@saivann
Drop use of mouseover and mouseout events on the wallet menu 
This is a workaround for iPads not firing the click event
for some unknown reason when mouseover events are triggered,
although this issue continues to happen in some cases which
don't affect the user experience really much.
c283a72

@saivann saivann referenced this pull request Jul 7, 2015

Merged

Rework menus for mobile compatibility #950

@saivann
Contributor

saivann commented Jul 7, 2015

This pull request has been replaced by #950

@saivann saivann closed this Jul 7, 2015

@saivann saivann deleted the saivann:walletonclick branch Jul 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment