Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Alerts: SPV Mining more details #936

Merged
merged 3 commits into from Jul 4, 2015

Conversation

Projects
None yet
3 participants
Contributor

harding commented Jul 4, 2015

This adds more details to the current alert message. With F2Pool now fully validating, I've also reduced the number of recommended extra confrimations to wait from 30 to 15. According to @gmaxwell's online version of the fork probability calculator, 15 confirmations on the longest chain from 25% of hash rate has a probability of 0.01%.

Preview: http://dg0.dtrt.org/en/alert/2015-07-04-spv-mining

CC: @petertodd @luke-jr

Contributor

luke-jr commented Jul 4, 2015

0.01% is too high IMO.

Contributor

harding commented Jul 4, 2015

@luke-jr I'll leave it at 30 then until we're sure more hash rate is safe.

Contributor

saivann commented Jul 4, 2015

@harding Thanks for writing this. Please find fixes for broken HTML here, last commit on this branch:
https://github.com/bitcoin-dot-org/bitcoin.org/commits/spv-smallfixes

I can't comment on the accuracy, but otherwise LGTM!

Contributor

harding commented Jul 4, 2015

Commit c04bfa6 changes the extra confirmations back to 30 and removes the text about SPV wallets being more vulnerable than usual because of expected soft fork problems. (Requested by @gmaxwell, who just said it looks good on IRC)

@harding harding merged commit 311044c into master Jul 4, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Contributor

harding commented Jul 4, 2015

Pushed commit 9f30adb to master with the following changes:

  • Move list of good/bad pools to the wiki. If we suspect people are lying about what validation their pools do, we can move the list back here; otherwise, I think letting people list their own pools will be a more productive use of everyone's time.
  • Suggest upgrading to 0.10.2 because of DoS vulnerabilities in earlier versions unrelated to this alert.
  • Update the times
Contributor

saivann commented Jul 4, 2015

@harding Thanks! Just fixed a typo with an additional commit.

Contributor

harding commented Jul 4, 2015

@saivann remember you need to sign tip commits (or update manually on the build server). I have another small change to make as recommended by reddit, so I'll push that in a moment after I see if there are any other good suggestions.

@harding harding deleted the spv-mining-fork branch Jul 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment