Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add more explicit RSS feed and other features from the blog layout to alerts #938
Conversation
|
I think you make it more explicit like on the blog At least with the words "Subscribe to the RSS feed" Your example has added the RSS button to the title of the alert, whereas I think you need a page header that includes the sub to RSS like you have on the blog page. |
|
Notice how individual blog post pages were dont on the blog |
|
@btcdrak I have just added a commit to reuse all the layout and features of the blog posts. Does that look better to you? Live preview: I'll have to do some more testing before being confident this pull request is ready to merge. |
saivann
changed the title from
Add RSS icon to individual alert pages
to
Add more explicit RSS feed and other features from the blog layout
Jul 4, 2015
saivann
changed the title from
Add more explicit RSS feed and other features from the blog layout
to
Add more explicit RSS feed and other features from the blog layout to alerts
Jul 4, 2015
|
In the absence of critical feedback, this pull request will be merged on July 5th. |
saivann
added
the
Merge Scheduled
label
Jul 4, 2015
|
Nicely done ACK |
|
7af80fc tested LGTM. Thanks! |
saivann commentedJul 4, 2015
@harding @btcdrak Would just adding the RSS icon into individual alerts would be good enough for now? Please feel free to merge this pull request at any time.This pull request adds RSS icons and other features from the blog post layout.
Live preview:
(Merged)