/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow to set styles for alert banner #940

Merged
merged 1 commit into from Jul 6, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Merge Scheduled
Projects
None yet
Milestone
No milestone
2 participants
@saivann @harding
@saivann
Contributor

saivann commented Jul 5, 2015

README: https://github.com/saivann/bitcoin.org/tree/alertclass#alerts

Screenshot of pre-selected colors:

capture du 2015-07-04 21 48 50
@saivann
Contributor

saivann commented Jul 5, 2015

Note; This pull request also sets the "warning" (orange / medium severity) class to the current alert, as suggested by @harding in #934 (comment)
@harding
Contributor

harding commented Jul 5, 2015

LGTM. Thanks!
@harding
Contributor

harding commented Jul 5, 2015

@saivann I thought things had improved, but we just had another 3-block fork. I think the banner should stay at red for now. (Sorry for changing my mind.)
@saivann
Contributor

saivann commented Jul 6, 2015

@harding That only sounds appropriate, I've set back the red alert class for the current alert at the same time that I had to rebase the commit to fix merge conflicts. So after merging, there should be no difference on the website, and it'll be easy to change the styles of the alert banner in the future.

In the absence of critical feedback, this pull request will be merged on July 6th.

@saivann saivann added the Merge Scheduled label Jul 6, 2015

@saivann saivann merged commit 2d36e36 into bitcoin-dot-org:master Jul 6, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@saivann saivann deleted the saivann:alertclass branch Jul 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment