Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

(Trivial) Build: Put Current Git Commit ID On Site #943

Merged
merged 1 commit into from Jul 6, 2015

Conversation

Projects
None yet
2 participants
Contributor

harding commented Jul 5, 2015

While testing an update to the build system, I needed this for easily tracking which of my automated local test builds were successful. However, I think it could also be useful for easily tracking what commit the site is on, so I'm submitting it as a separate PR. Here's what the command outputs on current HEAD:

63361be Merge branch 'buildvendor'

I'd like to merge this later today; if anyone thinks this single line needs more review, please say so.

Once we upgrade to >= Jekyll 2.0, I think it might be worth trying https://github.com/ivantsepp/jekyll-git_metadata to add the current commit to templates, kind of like how Reddit has its current commit id and render date at the bottom right of every page.

Contributor

saivann commented Jul 5, 2015

LGTM!

Contributor

harding commented Jul 5, 2015

@saivann thanks!

In the absence of critical feedback (or a request for more time to review) this will be merged today around 20:00 UTC.

@harding harding merged commit c536355 into bitcoin-dot-org:master Jul 6, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

harding added a commit that referenced this pull request Jul 6, 2015

Merge pulls #943 & #946
- #943: (Trivial) Build: Put Current Git Commit ID On Site
- #946: Alerts: Update SPV Mining Alert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment