/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Alerts: Update SPV Mining Alert #946

Merged
merged 3 commits into from Jul 6, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@harding @saivann @btcdrak
@harding
Contributor

harding commented Jul 6, 2015

Preview: http://dg0.dtrt.org/en/alert/2015-07-04-spv-mining

  • Add bolded notice to top telling people the event is on going. Some people on Reddit think it was a one-time fork.
  • Link Electrum users here for help finding a Bitcoin Core 0.10.x-powered server.
  • Add a table of forks related to SPV mining. Link to a list of invalid block hashes.
  • Remove hopeful note that miners were enabling full validation. This appears not to be the case. :-(
  • Add an update mentioning the July 5th fork

Also, used a hack to enable Markdown support. (Markdown allows inline HTML, so I didn't reformat anything I didn't have to. Tomorrow I may convert the whole thing to Markdown.)
@harding
Alerts: Update SPV Mining Alert
This commit was signed with a verified signature.
@harding harding David A. Harding
GPG key ID: 4B29C30FF29EC4B7 Learn about signing commits

Some checks haven’t completed yet

2 pending checks
continuous-integration/travis-ci/pr — The Travis CI build is in progress
Details
continuous-integration/travis-ci/push — The Travis CI build is in progress
Details
21e3f8c
@saivann
Contributor

saivann commented Jul 6, 2015

@harding Agreed with converting it all to markdown, that'll be helpful as an example for future alerts. Please feel free to pick what you think is relevant from #947, otherwise this LGTM! Thanks!

saivann and others added some commits Jul 6, 2015

@saivann @harding
Fix a typo
This commit was signed with a verified signature.
@harding harding David A. Harding
GPG key ID: 4B29C30FF29EC4B7 Learn about signing commits
b2e4b9b
@harding
Alerts: SPV Mining: Change Updates Style
This commit was signed with a verified signature.
@harding harding David A. Harding
GPG key ID: 4B29C30FF29EC4B7 Learn about signing commits

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
018724d

@harding harding merged commit 018724d into master Jul 6, 2015
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

harding added a commit that referenced this pull request Jul 6, 2015

@harding
Merge pulls #943 & #946 
- #943: (Trivial) Build: Put Current Git Commit ID On Site
- #946: Alerts: Update SPV Mining Alert
This commit was signed with a verified signature.
@harding harding David A. Harding
GPG key ID: 4B29C30FF29EC4B7 Learn about signing commits
312be98
@btcdrak
Contributor

btcdrak commented on _alerts/2015-07-04-spv-mining.html in 21e3f8c Jul 6, 2015

Is this UTC? you should mention the timezone.
Contributor

harding replied Jul 6, 2015

See line 9 (new) in this diff.
Contributor

btcdrak replied Jul 6, 2015

It's good, but I missed it, others will too. I think all times should be in full date time timezone format. We're talking about super critical information.
Contributor

harding replied Jul 6, 2015

I do like adding UTC as often as possible for clarity, but I had to drop it to allow the forks table to fit in thin mobile browsers. Next time I add an update, I'll add it back in where possible. Thanks!

@harding harding deleted the spv-mining-update2 branch Jul 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment