Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Allow Use Of Markdown For Alerts #948
Conversation
harding
and others
added some commits
Jul 6, 2015
|
I was skeptical that any change was needed in alerts.rb (or that the destination file should be a .md file), but after diff-ing the final pages, that's indeed the right way to do it! 7895b4c LGTM, Thanks! I opened a separate pull request to convert all HTML to markdown, however I don't think it should be blocking this PR if there is any issue with it or if it needs time to review. |
|
@saivann yeah, it confused me for a while too. I thought all that was broken was the alert banner, but the makefile tests caught the problem. Thanks for reviewing! In the absence of critical feedback, this pull will be merged (late) Tuesday. |
harding commentedJul 6, 2015
This PR makes it possible to write alerts in Markdown without having to use any hacks, and changes the current SPV mining alert to the new format (minimal changes). (HTML alerts still work and were tested.)
The changes to
_plugins/alerts.rbconsist entirely of getting it to use the right file name as the.htmlextension had been assumed.This PR is not urgent, so there's no rush to review.