Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Layouts: Allow Alternative Base Layouts & Add Breadcrumbs #957

Merged
merged 3 commits into from Jul 28, 2015

Conversation

Projects
None yet
2 participants
Contributor

harding commented Jul 10, 2015

Preview: http://dg1.dtrt.org/en/developer-documentation

This pull contains three commits:

  1. Split the base layout into multiple files: this makes it easy to create alternative layouts for collections of pages while reusing as much code as possible (so updates are easy). This pull does not use this feature, but I hope to use it in a future pull to create a "sub site" with a dozen pages dedicated to Bitcoin Core.

    Note: this commit diff is quite ugly because it produces HTML output that is identical to current master HEAD.

  2. Add whitespace to base layouts: this whitespace-only commit fixes the ugliness of the previous commit.

  3. Add breadcrumbs to dev docs: this changes the base template to allow adding breadcrumbs to pages, and proceeds to add them to all dev docs. They can be added to other pages too, but the dev docs seemed like a good place to test them out. Here's what they look like:

    screenshot-dg1 dtrt org 2015-07-10 11-46-10

Contributor

saivann commented Jul 25, 2015

@harding I haven't had time to review and test the changes yet but I think it's generally excellent ideas. If there is no hurry, I will likely be able to take a look very soon.

Contributor

harding commented Jul 25, 2015

@saivann there is no hurry, I'm still at least two weeks away from needing this merged. I'll try to rebase this tomorrow (Saturday) to fix the merge conflict.

harding added some commits Jun 28, 2015

Contributor

saivann commented Jul 27, 2015

LGTM up to commit 7d74941, thanks! That makes the layout way more understandable and modular.

I verified that the final output is identical (beside whitespaces) and content of each file in _includes is the same as the current base.html layout.

Contributor

harding commented Jul 27, 2015

@saivann thanks!

In the absence of critical feedback, this will be merged Monday.

@harding harding merged commit 7d74941 into bitcoin-dot-org:master Jul 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

harding added a commit that referenced this pull request Jul 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment