Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Layouts: Allow Alternative Base Layouts & Add Breadcrumbs #957
Conversation
|
@harding I haven't had time to review and test the changes yet but I think it's generally excellent ideas. If there is no hurry, I will likely be able to take a look very soon. |
|
@saivann there is no hurry, I'm still at least two weeks away from needing this merged. I'll try to rebase this tomorrow (Saturday) to fix the merge conflict. |
harding
added some commits
Jun 28, 2015
|
LGTM up to commit 7d74941, thanks! That makes the layout way more understandable and modular. I verified that the final output is identical (beside whitespaces) and content of each file in _includes is the same as the current base.html layout. |
|
@saivann thanks! In the absence of critical feedback, this will be merged Monday. |
harding commentedJul 10, 2015
Preview: http://dg1.dtrt.org/en/developer-documentation
This pull contains three commits:
Split the base layout into multiple files: this makes it easy to create alternative layouts for collections of pages while reusing as much code as possible (so updates are easy). This pull does not use this feature, but I hope to use it in a future pull to create a "sub site" with a dozen pages dedicated to Bitcoin Core.
Note: this commit diff is quite ugly because it produces HTML output that is identical to current master HEAD.
Add whitespace to base layouts: this whitespace-only commit fixes the ugliness of the previous commit.
Add breadcrumbs to dev docs: this changes the base template to allow adding breadcrumbs to pages, and proceeds to add them to all dev docs. They can be added to other pages too, but the dev docs seemed like a good place to test them out. Here's what they look like: