Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Added Coin.Space wallet #963
Conversation
harding
added
the
Wallets
label
Jul 19, 2015
voisine
pushed a commit
to voisine/bitcoin.org
that referenced
this pull request
Jul 20, 2015
|
I have reviewed Coin.Space based on the current wallet requirements criteria and my evaluation is below. The summary is that I found nothing wrong with the overall architecture. However, because of the insufficient usage based feedback and the bugs that I noted in the review (one of which being quite serious), I cannot at this time recommend it for listing as it may be too immature for general use. I would be happy to re-review Coin.Space after the issues have been addressed and sufficient usage has been identified. The requirements also provide for an independent audit as an alternative to usage feedback which Coin Space was happy to look into. Coin.Spacev0.1.5Review Version 2015072401The wallet list is based on the personal evaluation of the maintainer(s) and regular contributors of this site, according to the criterias detailed below. These requirements are meant to be updated and strengthened over time. Innovative wallets are exciting and encouraged, so if your wallet has a good reason for not following some of the rules below, please submit it anyway and we'll consider updating the rules. NOTE OpenAlias support was demonstrated, but security considerations were not reviewed Basic requirements:
NOTE No evidence of usage on Reddit http://www.reddit.com/r/Bitcoin/comments/30lyvx/coinspace_hd_wallet_for_android_released/ NOTE Facebook page https://www.facebook.com/coinspacewallet has over 4000 likes, but it is uncertain how to relate that to users NOTE No substantive reviews on http://www.windowsphone.com/ NOTE Google Play: 100-500 downloads, 17 ratings, all reviews non substantive NOTE No users on bitcointalk.org NOTE No users found with generic searches using Google and Bing NOTE No independent security audit is available, but Coin Space is receptive to having one FAIL Insufficient evidence of usage found to conclude that there are no concerning issues
PASS No indication found
NOTE Bug bounty at https://hackerone.com/coinspace PASS No indication found
PASS Uses BitcoinJS, CryptoJS, and secure-random
PASS No indication found. Some tests are on github.
PASS Android 28-Mar-2015 http://www.coinspace.ch/blog/android-client PASS Windows Phone 22-Apr-2015 (exactly 3 months) http://www.coinspace.ch/blog/windows-phone-app
FAIL A number of concerning bugs were found and reported. Following are some in no particular order other than the first being the most concerning.
FAIL http://www.coinspace.ch which links to downloads does not redirect to https PASS http://coin.space web wallet redirects correctly
PASS https://coinspace.ch (links to downloads): A+ rating (with Cloudflare) PASS https://coin.space (wallet): A rating (with Cloudflare)
PASS https://coinspace.ch 180 days PASS https://coin.space 180 days
PASS Link to Crunchbase on https://www.coinspace.ch/about.html
NOTE An encryption key is stored online that is used to decrypt local wallet storage.
PASS Aggressive lockout: Account is deleted after five failed PINs. NOTE No filter for common PINs. NOTE Recovery process is full restore from BIP39 phrase.
N/A
PASS Wallet backup is BIP39 phrase
PASS Wallet was restored from BIP39 phrase. Wallet was also restored to MultiBit HD using BIP39 phrase.
PASS https://github.com/skyjam/CoinSpace CONCERN There is only one version tagged, v0.1.5.
N/A
N/A
Optional criterias (some could become requirements):
FAIL No audit currently, but Coin Space has expressed interest in conducting an audit
PASS Uses a new change address for each transaction
FAIL In a running wallet, after a new confirmed received transaction is displayed on the History tab, the same receive address is displayed for reuse on the Receive tab. NOTE Wallet does eventually provide a new receive addresses after some unknown time period/conditions
PASS Does not show received from addresses
PASS A transaction created by the wallet was re-signed using custom code compatible with RFC 6979 and the signatures matched.
PASS A contact form is provided https://www.coinspace.ch/contact.html
N/A
PASS Supports BIP32 using standard m/0'/c/i path
PASS Provides BIP39 phrase on setup and encourages users to write it down NOTE Wallet seed is never available to end users after setup CONCERN There is a feature that encourages users to send their BIP39 phrase in an unencrypted SMS message during setup
PASS KDF is not used. The server provides a strong key when the correct PIN is supplied. NOTE This requires the server to be available to access the wallet in any way
PASS Local wallet storage is encrypted by default
N/A |
|
@crwatkins At the risk of repeating myself, huge thanks again for your work on this! |
nikashitsa
commented
Jul 25, 2015
|
@crwatkins @saivann thank you for the great review! We are going to fix all Fails soon. |
|
@nikashitsa, I would like to point out the precedence of my |
nikashitsa
commented
Aug 4, 2015
|
@crwatkins we have fixed all found issues and released v0.1.6. |
|
@nikashitsa Great! That was certainly fast. Can you comment on the status of an audit (or otherwise provide feedback)? In addition, can you comment on your intentions on sending BIP39 phrases in the clear over SMS (see my above comment)? |
ghost
commented
Aug 5, 2015
|
I have contacted all the suggested individuals to complete an audit Coinspace but received no reply. Is possible this is being viewed as an unsolicited contact. Losing the pass phrase seems to a common issue for BIP39 web wallet users. We can review removing the SMS BIP39 phrase reminder but feel that its only an option and in no way encouraged, only offered on an opt in basis. |
nikashitsa
commented
Aug 5, 2015
|
@crwatkins Your review is really detailed and contains only objective comments. Thank you. |
harding
added
the
Need more info
label
Sep 9, 2015
|
FWIW, I've previously opposed to merging Airbitz until they stopped sending their seed unencrypted over email. I still think it's not appropriate and having these seeds encrypted before sending them in the cloud would be a fair requirement. |
ghost
commented
Nov 18, 2015
|
@saivann CoinSpace doesn't send seed over email. |
jspeigner
commented
Jan 8, 2016
|
Just wanted to post an update here that CoinSpace is now in the Apple App Store now. |
Cobra-Bitcoin
closed this
Mar 23, 2016
jspeigner
commented
Mar 24, 2016
|
Why was this closed? |
nikashitsa commentedJul 14, 2015
Coin.Space HD Wallet is a free online bitcoin wallet, which you can use to make worldwide payments for free. It makes paying with bitcoins easy and secure available anywhere on your phone or desktop.