Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Alerts: Disable SPV Mining Alert #964
Conversation
|
Untested LGTM e509a92 |
|
Since the Reddit and Bitcoin Talk alerts have been un-stickied, I'm going to merge this pull in a couple hours if there are no further comments. |
harding
merged commit e509a92
into
master
Jul 16, 2015
harding
deleted the
disable-spv-alert branch
Jul 31, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
harding commentedJul 15, 2015
This PR removes the alert banner from every page of the site and changes the bolded text near the top of the alert to:
I'm not sure we should be disabling the alert banner: if I understand correctly, several large miners have decided to stay with SPV mining (or worse, previous-header-hash-only mining).
On the other hand, I'm not aware of any short-term proposals to restore SPV wallet confirmation reliability to what it was when every miner did full validation---so the alternative seems to be keeping this alert up indefinitely, and I don't want to do that.
Comments appreciated.