/bitcoin.org

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Copyrights: Add MIT License Header To More Files #966

Merged
merged 1 commit into from Jul 26, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Merge Scheduled
Projects
None yet
Milestone
No milestone
2 participants
@harding @saivann
@harding
Contributor

harding commented Jul 19, 2015

This pull updates the existing makefile test for copyright headers to also cover all files with a YAML header except those in the _alerts directory. (I don't want anything to stop us from quickly publishing an alert.)

The rest of this pull adds any missing copyright headers. I believe all the files with newly-added headers either came from the Bitcoin Core project (release notes), which is MIT licensed, or were created by @saivann or me.
@harding
Copyrights: Add MIT License Header To More Files 
- Makefile: extend copyright check test to scan all files with YAML
  headers

    - Exclude alerts from check -- lack of a license shouldn't prevent
      us from publishing emergency information

    - Also add license to Makefile itself

- Fix all errors caught by new test

    - For release notes, also link to github.com/bitcoin/bitcoin
      repository as origin

        - Also update README.md release instructions to include license
This commit was signed with a verified signature.
@harding harding David A. Harding
GPG key ID: 4B29C30FF29EC4B7 Learn about signing commits
e038560
@saivann
Contributor

saivann commented Jul 25, 2015

Commit e038560 LGTM, thanks for improving the Makefile rule!
@harding
Contributor

harding commented Jul 25, 2015

@saivann thanks!

In the absence of critical feedback, this will be merged Sunday.

@harding harding added the Merge Scheduled label Jul 25, 2015

@harding harding merged commit e038560 into bitcoin-dot-org:master Jul 26, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

harding added a commit that referenced this pull request Jul 26, 2015

@harding
Merge pull #966: Copyrights: Add MIT License Header To More Files
This commit was signed with a verified signature.
@harding harding David A. Harding
GPG key ID: 4B29C30FF29EC4B7 Learn about signing commits
ae2c7b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment