Pull request for spanish translation first review

[adrianbertini]

First review for spanish translation.

[saivann]

There was already one spanish translation ongoing there : bitcoin#96 . I suggested the owner of this repository to review and include your work in its own branch. This might allows us to fix all the following problems in one shot :

To start with, the first step in the README was apparently ignored. Which leads to many inconsistencies.

1. The language is not in _contrib.yml, and it doesn't appear in the language bar.
2. Many files in /es/ uses base_en as layout (so you get spanish pages with english content)
3. There is many deadlinks (like the Personas menu that doesn't point to the right url).
4. urls are missing in the _config.yml file, so the website cannot associate each spanish page with its equivalent.
5. Many files where ISO-8859-15 encoded. It is required to use a text editor that will produce UTF-8 encoded texts otherwise the website fails to build and some characters might not display correctly one published. I tried to convert everything to UTF-8 to build this, but I don't know if the resulting characters are appropriate.

Thiis pull request is published and live here : http://bitcoines.zapto.org/es/

Thanks for your work, it amazes me that you succeeded to do all this hard work within a short time like this.

[adrianbertini]

Thanks for your advice and sorry for my mistakes, this is my first time
with github.

I try to correct all mistakes but cant try the site local (im installing
rails to do that). I you want i can request a pull again and test in this
url http://bitcoines.zapto.org/es/.

Thank you!

On Wed, Mar 27, 2013 at 6:11 PM, saivann notifications@github.com wrote:

There was already one spanish translation ongoing there : #96bitcoin#96
I suggested the owner of this repository to review and include your work
in its own branch. This might allow us to fix all the following problems in
one shot :

To start with, the first step in the README was apparently ignored. Which
leads to many inconsistencies.

1. The language is not in _contrib.yml, and it doesn't appear in the
   language bar.
2. Many files in /es/ uses base_en as layout (so you get spanish pages
   with english content)
3. There is many deadlinks (like the Personas menu that doesn't point
   to the right url).
4. urls are missing in the _config.yml file, so the website cannot
   associate each spanish page with its equivalent.
5. Many files where ISO-8859-15 encoded. It is required to use a text
   editor that will produce UTF-8 encoded texts otherwise the website fails to
   build. I tried to convert everything to UTF-8 to build this, but I don't
   know if the resulting characters are appropriate.

Thiis pull request is published and live here :
http://bitcoines.zapto.org/es/

—
Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin.org/pull/97#issuecomment-15553376
.

[saivann]

Just so that we don't uselessly duplicate efforts, I would say it's maybe simplier to wait for the other translation from enersto in issue #96 to be completed (there is only a few pages left and he's aware of your pull request). Once this pull request is published, we can review it against yours if there is anything that requires discussion.

[saivann]

There it is, the other translation is ready for review. You can find it there : bitcoin#104

If you have time to review it and comment if you find any typo or other required fixes, it's appreciated.

Thanks!

[saivann]

Closing the pull request as the other pull request seems pretty mature now