Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix libbitcoin, urls, descriptions, split blkmaker, drop BOP, sort. #971

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

evoskuil commented Jul 23, 2015

SX has been replaced by Bitcoin Explorer (bx) and Obelisk has been replaced by Bitcoin Server (bs). These are both based on the libraries libbitcoin-explorer and libbitcoin-server, among others.

@luke-jr luke-jr and 1 other commented on an outdated diff Jul 23, 2015

_templates/development.html
@@ -39,23 +39,23 @@ <h2 id="more">{% translate more %}</h2>
<ul class="devprojectlist">
<li><a href="https://github.com/etotheipi/BitcoinArmory">Armory</a> - A Bitcoin client with enhanced security features.</li>
- <li><a href="http://bfgminer.com">BFGMiner</a> - Modular Bitcoin mining software.</li>
- <li><a href="https://code.google.com/p/bitcoinj/">bitcoinj</a> - A Java implementation of a Bitcoin client-only node used in thin SPV Bitcoin clients.</li>
- <li><a href="https://github.com/schildbach/bitcoin-wallet/">Bitcoin Wallet for Android</a> - A thin SPV Bitcoin client for mobiles.</li>
- <li><a href="https://github.com/bitsofproof/supernode">Bits of Proof Enterprise Bitcoin Server</a> - A modular implementation of the Bitcoin protocol in Java.</li>
+ <li><a href="http://bfgminer.com">BFGMiner</a> - A modular ASIC/FPGA Bitcoin miner.</li>
@luke-jr

luke-jr Jul 23, 2015

Contributor

Not sure what the purpose of this change is. BFGMiner supports CPU/GPU/FPGA/ASIC, but only ASIC makes sense for Bitcoin usually.

@evoskuil

evoskuil Jul 23, 2015

Contributor

I was verifying and clarifying info in general. That description was pulled directly from the website.

@harding harding commented on an outdated diff Jul 23, 2015

_templates/development.html
<li><a href="https://github.com/btcsuite/btcd">btcd</a> - A full node bitcoin implementation written in Go.</li>
<li><a href="https://github.com/btcsuite/btcwallet">btcwallet</a> - A hierarchical deterministic wallet daemon written in Go.</li>
- <li><a href="https://electrum.org/community.html">Electrum</a> - A fast Bitcoin client relying on remote servers to store the block chain.</li>
+ <li><a href="https://electrum.org">Electrum</a> - A fast Bitcoin client relying on remote servers to store the blockchain.</li>
@harding

harding Jul 23, 2015

Contributor

The style used on Bitcoin.org is "block chain".

@harding harding and 1 other commented on an outdated diff Jul 23, 2015

_templates/development.html
<li><a href="https://github.com/luke-jr/eloipool">Eloipool</a> - A fast Python mining pool server software.</li>
- <li><a href="https://github.com/hivewallet">Hive</a> - A fast user-friendly SPV Bitcoin client.</li>
- <li><a href="https://github.com/libbitcoin/libbitcoin/">libbitcoin</a> - An asynchronous C++ library for Bitcoin.</li>
- <li><a href="https://en.bitcoin.it/wiki/Libblkmaker#For_developers">libblkmaker and python-blkmaker</a> - Client side libraries for the getblocktemplate mining protocol.</li>
- <li><a href="https://multibit.org/">MultiBit HD</a> - A thin SPV international Bitcoin client for desktops.</li>
+ <li><a href="https://github.com/hivewallet">Hive</a> - A fast user-friendly SPV Bitcoin wallet.</li>
+ <li><a href="https://en.bitcoin.it/wiki/Libbitcoin">Libbitcoin</a> - A Bitcoin cross-platform C++ development toolkit.</li>
+ <li><a href="https://gitlab.com/bitcoin/libblkmaker">Libblkmaker</a> - A C client library for the getblocktemplate mining protocol.</li>
+ <li><a href="https://multibit.org">MultiBit HD</a> - A thin SPV international Bitcoin client for desktops.</li>
@harding

harding Jul 23, 2015

Contributor

It looks like you changed Hive to "wallet" but left this as "client". Was that an oversight?

@evoskuil

evoskuil Jul 23, 2015

Contributor

Yes, it should really be more consistent. The term client is confusing as used. I've made an additional commit to improve consistency between wallet and client. I also removed the word "Bitcoin", which ended up as a qualifier for every entry.

@harding harding and 1 other commented on an outdated diff Jul 23, 2015

_templates/development.html
@@ -39,23 +39,23 @@ <h2 id="more">{% translate more %}</h2>
<ul class="devprojectlist">
<li><a href="https://github.com/etotheipi/BitcoinArmory">Armory</a> - A Bitcoin client with enhanced security features.</li>
- <li><a href="http://bfgminer.com">BFGMiner</a> - Modular Bitcoin mining software.</li>
- <li><a href="https://code.google.com/p/bitcoinj/">bitcoinj</a> - A Java implementation of a Bitcoin client-only node used in thin SPV Bitcoin clients.</li>
- <li><a href="https://github.com/schildbach/bitcoin-wallet/">Bitcoin Wallet for Android</a> - A thin SPV Bitcoin client for mobiles.</li>
- <li><a href="https://github.com/bitsofproof/supernode">Bits of Proof Enterprise Bitcoin Server</a> - A modular implementation of the Bitcoin protocol in Java.</li>
+ <li><a href="http://bfgminer.com">BFGMiner</a> - A modular Bitcoin miner.</li>
+ <li><a href="https://en.bitcoin.it/wiki/Bitcoin_Explorer">Bitcoin Explorer</a> - A Bitcoin command line tool, built on libbitcoin.</li>
+ <li><a href="https://en.bitcoin.it/wiki/Bitcoin_Server">Bitcoin Server</a> - A Bitcoin full node and query server, built on libbitcoin.</li>
+ <li><a href="https://github.com/schildbach/bitcoin-wallet">Bitcoin Wallet</a> - A thin SPV Bitcoin client for Android.</li>
@harding

harding Jul 23, 2015

Contributor

I think this should continue to say "Bitcoin Wallet for Android" in the link. Also, you updated Hive below to say "wallet" but this continues to say "client". I suggest we choose one term and use it consistently for lightweight wallets.

@schildbach

schildbach Jul 23, 2015

Contributor

I'd like to add that Bitcoin Wallet is also available for BlackBerry OS.

Contributor

harding commented Jul 23, 2015

@evoskuil thanks for updating the links and descriptions. I added some comments, but besides that it looks good to me.

Contributor

evoskuil commented Jul 23, 2015

@harding Thanks for looking it over, and for your work on the site.

Contributor

harding commented Jul 24, 2015

Commit 5e842a3 looks good to me, and addresses all posted feedback. Thanks!

In the absence of critical feedback, this will be merged on Saturday.

@harding harding closed this in 3b15976 Jul 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment