Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Combine /index, /<lang>/index, and /404 #975
Conversation
|
That's indeed better, thanks! |
|
@saivann thanks! In the absence of critical feedback, this will be merged around 16:00 UTC Saturday. |
harding
added
the
Merge Scheduled
label
Jul 25, 2015
harding
merged commit d1f49ba
into
bitcoin-dot-org:master
Jul 26, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
harding
added a commit
that referenced
this pull request
Jul 26, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
harding commentedJul 24, 2015
When working on #972, I discovered Bitcoin.org has three pages with nearly identical content:
/<language>/index.htmlwhich provides the Bitcoin.org index page localized into each supported language/index.htmlwhich provides a fallback in case language redirection doesn't work. This page is currently identical to the English localized index page./404.htmlwhich provides the 404 error page, which includes a Javascript redirect to the localized index page plus fallback content that looks like an old version of the English localized index page.This PR now builds all three pages from the same source so that if we change any text, we only have to change it once. (No text changes are introduced in this PR, except that text displayed on the 404 page is now identical to the text displayed on the index pages.)
I tested this for English and Spanish.