Optimize and Clean up WalletRpcTest #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christewart
reviewed
Jun 4, 2020
| @@ -357,9 +357,13 @@ class WalletRpcTest extends BitcoindRpcTest { | |||
| } | |||
|
|
|||
| it should "be able to import an address" in { | |||
|
|
|||
| val address = Bech32Address | |||
There was a problem hiding this comment.
Why have this hard coded?
There was a problem hiding this comment.
So we don't need to fetch an address from one of the clients, one less thing that can fail
Christewart
reviewed
Jun 4, 2020
testkit/src/main/scala/org/bitcoins/testkit/rpc/BitcoindRpcTestUtil.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be able to import an addresswould sometimes fail because the receiver would not have seen the block yet, now if it hasn't seen it we will publish the block from that client as well.